From: Baruch Even <baruch@ev-en.org>
To: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Cc: Baruch Even <baruch@ev-en.org>
Subject: [PATCH 1/1] [libata] SCSI: really use SATL version in VPD
Date: Fri, 5 Apr 2013 17:50:25 +0300 [thread overview]
Message-ID: <1365173425-16599-1-git-send-email-baruch@ev-en.org> (raw)
In-Reply-To: <satl-driver-version-v2>
As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD)
We need to provide the SATL driver version and not the disk firmware version
but the code overwrites the driver version with the disk version.
Signed-off-by: Baruch Even <baruch@ev-en.org>
---
drivers/ata/libata-scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 318b413..e61a054 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf)
memcpy(&rbuf[8], "linux ", 8);
memcpy(&rbuf[16], "libata ", 16);
memcpy(&rbuf[32], DRV_VERSION, 4);
- ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4);
/* we don't store the ATA device signature, so we fake it */
--
1.7.10.4
next parent reply other threads:[~2013-04-05 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <satl-driver-version-v2>
2013-04-05 14:50 ` Baruch Even [this message]
2013-04-05 15:24 ` [PATCH 1/1] [libata] SCSI: really use SATL version in VPD Sergei Shtylyov
[not found] <satl-driver-version>
2013-04-05 11:48 ` Baruch Even
2013-04-05 14:44 ` Sergei Shtylyov
2013-04-05 14:51 ` Baruch Even
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365173425-16599-1-git-send-email-baruch@ev-en.org \
--to=baruch@ev-en.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).