From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc C Subject: [PATCH] libata: bugfix: Remove __le32 in ata_tf_to_fis Date: Sun, 1 Sep 2013 08:59:01 -0700 Message-ID: <1378051141-2652-1-git-send-email-marc.ceeeee@gmail.com> Return-path: Received: from mail-oa0-f50.google.com ([209.85.219.50]:49149 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757712Ab3IAP7V (ORCPT ); Sun, 1 Sep 2013 11:59:21 -0400 Received: by mail-oa0-f50.google.com with SMTP id i4so4306716oah.37 for ; Sun, 01 Sep 2013 08:59:18 -0700 (PDT) Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: tj@kernel.org, linux-ide@vger.kernel.org Cc: Marc Carino From: Marc Carino The endianness attribute on the 'aux' local variable is a wrong, and can lead to issues on big-endian machines, Signed-off-by: Marc Carino --- drivers/ata/libata-core.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index a044be9..83b1a9f 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -546,8 +546,6 @@ int atapi_cmd_type(u8 opcode) */ void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis) { - const __le32 aux = cpu_to_le32(tf->auxiliary); - fis[0] = 0x27; /* Register - Host to Device FIS */ fis[1] = pmp & 0xf; /* Port multiplier number*/ if (is_cmd) @@ -571,10 +569,10 @@ void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis) fis[14] = 0; fis[15] = tf->ctl; - fis[16] = aux & 0xff; - fis[17] = (aux >> 8) & 0xff; - fis[18] = (aux >> 16) & 0xff; - fis[19] = (aux >> 24) & 0xff; + fis[16] = tf->auxiliary & 0xff; + fis[17] = (tf->auxiliary >> 8) & 0xff; + fis[18] = (tf->auxiliary >> 16) & 0xff; + fis[19] = (tf->auxiliary >> 24) & 0xff; } /** -- 1.8.1.2