From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: todd.e.brandt@linux.intel.com
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org
Subject: Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization
Date: Fri, 06 Sep 2013 08:10:34 -0700 [thread overview]
Message-ID: <1378480234.2063.16.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <20130906004425.GA31998@linux.intel.com>
On Thu, 2013-09-05 at 17:44 -0700, Todd E Brandt wrote:
> Part 2 of the hard disk resume optimization patch, this one applies
> to the scsi subsystem.
This is a horrible patch description, it won't tell the next reader
anything about what is going on and why. Give the patches two separate
summaries and refer back by summary explaining what this one does.
Also, having two code paths do the same thing is always a bad idea:
someone will update one and not the other. sd_resume() should be come
sd_resume_async(); wait for async event
James
next prev parent reply other threads:[~2013-09-06 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 0:44 [PATCH/RESEND 2/2] Hard disk S3 resume time optimization Todd E Brandt
2013-09-06 12:37 ` Sergei Shtylyov
2013-09-06 15:10 ` James Bottomley [this message]
2013-09-06 17:03 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378480234.2063.16.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox