From: Joe Perches <joe@perches.com>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ahci: Changing two module params with static and __read_mostly
Date: Tue, 17 Sep 2013 09:24:24 -0700 [thread overview]
Message-ID: <1379435064.2012.8.camel@joe-AO722> (raw)
In-Reply-To: <1379436518.26153.31.camel@cliu38-desktop-build>
On Wed, 2013-09-18 at 00:48 +0800, Chuansheng Liu wrote:
> Here module parameters ahci_em_messages and devslp_idle_timeout can
> be set as static and __read_mostly.
>
> Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
> ---
> drivers/ata/libahci.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
[]
> @@ -189,14 +189,15 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
> };
> EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
>
> -int ahci_em_messages = 1;
> +static int ahci_em_messages __read_mostly = 1;
This one could also be converted to
static bool ahci_em_messages __read_mostly = true;
next prev parent reply other threads:[~2013-09-17 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 16:48 [PATCH] ahci: Changing two module params with static and __read_mostly Chuansheng Liu
2013-09-17 16:24 ` Joe Perches [this message]
2013-09-18 2:52 ` Liu, Chuansheng
2013-09-18 12:21 ` [PATCH V2] " Chuansheng Liu
2013-09-22 16:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379435064.2012.8.camel@joe-AO722 \
--to=joe@perches.com \
--cc=chuansheng.liu@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).