From: Paul Bolle <pebolle@tiscali.nl>
To: Levente Kurusa <levex@linux.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ahci: only attach ICH6-M if it's in SATA mode
Date: Mon, 16 Dec 2013 21:47:32 +0100 [thread overview]
Message-ID: <1387226852.14970.28.camel@x41.thuisdomein> (raw)
In-Reply-To: <52AF384C.9020101@linux.com>
On Mon, 2013-12-16 at 18:28 +0100, Levente Kurusa wrote:
> Not only they use different class IDs, but IIRC they also change device ids.
> For example, ICH7M was 0x27C4 in AHCI mode and 0x27DF in IDE mode. (obviously
> Intel vendor ids)
Apparently ICH6-M always uses device ID 0x2653 for its SATA "function"
(whether in SATA mode or in IDE mode).
> Paul, did this patch change anything noticeable for you? I mean was there any
> problem before that this patch fixes or not?
What triggered these two patches was the warning I quoted in patch 1/2
(which Tejun already queued). Looking at the code involved raised the,
obvious, question why ahci bothers to attach to ICH6-M in IDE mode.
Anyhow, the only problem is that it unsuccessfully probes when ICH6-M is
in IDE mode. The probe doesn't break things, as far as I can tell.
Paul Bolle
next prev parent reply other threads:[~2013-12-16 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 10:34 [PATCH 2/2] ahci: only attach ICH6-M if it's in SATA mode Paul Bolle
2013-12-16 15:51 ` Tejun Heo
2013-12-16 17:28 ` Levente Kurusa
2013-12-16 20:47 ` Paul Bolle [this message]
2013-12-16 20:28 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387226852.14970.28.camel@x41.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=levex@linux.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox