From: Aaron Lu <aaron.lu@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: [PATCH 2/3] libata: acpi: avoid passing NULL to ACPI evaluation method
Date: Fri, 14 Mar 2014 13:46:09 +0800 [thread overview]
Message-ID: <1394775970-6022-3-git-send-email-aaron.lu@intel.com> (raw)
In-Reply-To: <1394775970-6022-1-git-send-email-aaron.lu@intel.com>
If ACPI handle for an ATA device is NULL, we shouldn't call
ata_dev_get_GTF as that function will use handle to do some ACPI
evaluation.
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Cc: stable@vger.kernel.org
---
drivers/ata/libata-acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 9e69a5308693..b4f7cc2522d9 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -835,6 +835,7 @@ void ata_acpi_on_resume(struct ata_port *ap)
ata_for_each_dev(dev, &ap->link, ALL) {
ata_acpi_clear_gtf(dev);
if (ata_dev_enabled(dev) &&
+ ata_dev_acpi_handle(dev) &&
ata_dev_get_GTF(dev, NULL) >= 0)
dev->flags |= ATA_DFLAG_ACPI_PENDING;
}
--
1.8.5.3
next prev parent reply other threads:[~2014-03-14 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 5:46 [PATCH 0/3] ata: acpi/zpodd: some small fixes Aaron Lu
2014-03-14 5:46 ` [PATCH 1/3] libata: zpodd: should depend on PM_RUNTIME Aaron Lu
2014-03-14 5:46 ` Aaron Lu [this message]
2014-03-14 12:58 ` [PATCH 2/3] libata: acpi: avoid passing NULL to ACPI evaluation method Tejun Heo
2014-03-14 14:25 ` Aaron Lu
2014-03-14 14:32 ` Aaron Lu
2014-03-14 14:33 ` Tejun Heo
2014-03-14 15:18 ` Aaron Lu
2014-03-14 5:46 ` [PATCH 3/3] libata: zpodd: eliminate odd_can_poweroff Aaron Lu
2014-03-14 15:24 ` [PATCH 0/3] ata: acpi/zpodd: some small fixes Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394775970-6022-3-git-send-email-aaron.lu@intel.com \
--to=aaron.lu@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).