From: Paul Bolle <pebolle@tiscali.nl>
To: Alan Cox <alan@linux.intel.com>
Cc: David Howells <dhowells@redhat.com>, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata-sff: remove dead code
Date: Wed, 07 May 2014 11:23:24 +0200 [thread overview]
Message-ID: <1399454604.6659.13.camel@x220> (raw)
In-Reply-To: <1399411616.2458.45.camel@acox1-desk.ger.corp.intel.com>
[Added David.]
On Tue, 2014-05-06 at 22:26 +0100, Alan Cox wrote:
> On Sun, 2014-05-04 at 13:50 +0200, Paul Bolle wrote:
> > Ever since v2.6.19 the code contains a check for CONFIG_NO_ATA_LEGACY.
> > But that macro has never been defined. Apparently no one ran into
> > problems on platforms that do not support compatibility mode.
>
> It was needed for some of the FRV devices I belive. Please check with
> David Howells if it's still relevant
This code has been behind (effectively) an "#if 0" check for seven
years. So either there was no problem to begin with, the problem is
fixed somewhere else, or no one is actually using the affected devices.
So I doubt this is still relevant. But maybe David thinks otherwise...
> (even if its not used in the default configs)
It's not used (and has never been used) regardless which config one
tries.
Paul Bolle
next prev parent reply other threads:[~2014-05-07 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 11:50 [PATCH] libata-sff: remove dead code Paul Bolle
2014-05-06 21:26 ` Alan Cox
2014-05-07 9:23 ` Paul Bolle [this message]
2014-05-07 9:49 ` Alan Cox
2014-05-07 10:00 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399454604.6659.13.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=alan@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).