From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: remove the cmd_type field from struct request
Date: Tue, 31 Jan 2017 13:07:01 -0800 [thread overview]
Message-ID: <13b5993e-5b1b-696c-cdea-50c1ffade5ec@kernel.dk> (raw)
In-Reply-To: <1485878251-6107-1-git-send-email-hch@lst.de>
On 01/31/2017 07:57 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> this series gets rid of the cmd_type field in struct request and
> instead folds it into the REQ_OP* space. This reduces the size of
> struct request, and leads to a single op namespace that drivers
> can easily switch on. Except for the legacy ide driver which has
> a mess of different request types [1] this also nicely cleans up the
> code.
>
> Note that the patches are on top of the
>
> "make SCSI passthrough support optional"
>
> series I sent out on Saturday. To make life easier I also have a git
> tree available here:
>
> git://git.infradead.org/users/hch/block.git cmd_type
>
> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/cmd_type
Looks good to me, applied for 4.11.
--
Jens Axboe
next prev parent reply other threads:[~2017-01-31 21:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 15:57 remove the cmd_type field from struct request Christoph Hellwig
2017-01-31 15:57 ` [PATCH 01/10] scm_blk: remove unneeded REQ_TYPE_FS check Christoph Hellwig
2017-01-31 15:57 ` [PATCH 02/10] ѕd: remove pointless " Christoph Hellwig
2017-01-31 15:57 ` [PATCH 03/10] mmc: remove pointless request type check in mmc_prep_request Christoph Hellwig
2017-01-31 15:57 ` [PATCH 04/10] ms_block: remove pointless prep_fn Christoph Hellwig
2017-01-31 15:57 ` [PATCH 05/10] mspro_block: " Christoph Hellwig
2017-01-31 15:57 ` [PATCH 06/10] nbd: remove REQ_TYPE_DRV_PRIV leftovers Christoph Hellwig
2017-01-31 15:57 ` [PATCH 07/10] nbd: move request validity checking into nbd_send_cmd Christoph Hellwig
2017-01-31 15:57 ` [PATCH 08/10] block: introduce blk_rq_is_passthrough Christoph Hellwig
2017-01-31 15:57 ` [PATCH 09/10] ide: don't abuse cmd_type Christoph Hellwig
2017-01-31 16:11 ` David Miller
2017-01-31 15:57 ` [PATCH 10/10] block: fold cmd_type into the REQ_OP_ space Christoph Hellwig
2017-01-31 18:02 ` remove the cmd_type field from struct request Jens Axboe
2017-01-31 18:51 ` James Bottomley
2017-01-31 18:58 ` Sergei Shtylyov
2017-01-31 21:09 ` Jens Axboe
2017-02-01 6:53 ` Hannes Reinecke
2017-02-01 10:55 ` Sergei Shtylyov
[not found] ` <CGME20170201103729epcas1p12708473d0e5257bef65e1d92712af885@epcas1p1.samsung.com>
2017-02-01 10:37 ` Bartlomiej Zolnierkiewicz
2017-01-31 21:07 ` Jens Axboe [this message]
2017-02-01 2:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13b5993e-5b1b-696c-cdea-50c1ffade5ec@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).