From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
falcon@meizu.com, tiwai@suse.de, tj@kernel.org,
arjan@linux.intel.com
Cc: linux-kernel@vger.kernel.org, oleg@redhat.com, hare@suse.com,
akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp,
joseph.salisbury@canonical.com, bpoirier@suse.de,
santosh@chelsio.com, "Luis R. Rodriguez" <mcgrof@suse.com>,
linux-ide@vger.kernel.org,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
patrakov@gmail.com
Subject: [RFC v2 6/6] pata_marvell: use async probe
Date: Thu, 4 Sep 2014 23:37:27 -0700 [thread overview]
Message-ID: <1409899047-13045-7-git-send-email-mcgrof@do-not-panic.com> (raw)
In-Reply-To: <1409899047-13045-1-git-send-email-mcgrof@do-not-panic.com>
From: "Luis R. Rodriguez" <mcgrof@suse.com>
Alexander reported that on his Sony VAIO VPCZ23A4R laptop
experiences long delays on boot when connected to its dock
station on pre 3.9 kernels but anything after 3.9 will cause
the device to not be detected at all ending with:
[ 38.065673] pata_marvell 0000:1a:00.0: no available native port
[ 38.065769] pata_acpi 0000:1a:00.0: no available native port
This laptop has a Marvell 88SE6121 SATA II Controller [11ab:6121]
and a BluRay writer attached. The reason for the delays are
caused by SRST errors and the link being slow to respond.
The pata_marvell driver is a simple libata wrapper so the
real required changes need to be made on libata however not
many folks are around and available anymore with intimate
knowledge and experience with these devices. Alexander notes
that it may be that *any* ATA BMDMA controller that fails to
respond to an identify command until a reset or other device
poking might suffer from similar fate, this needs to be
investigated further. Using async probe the issue caused
by systemd killing the driver after taking over 30 seconds
on probe.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=59581
Cc: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Benjamin Poirier <bpoirier@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: patrakov@gmail.com
Reported-by: "Alexander E. Patrakov" <patrakov@gmail.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---
drivers/ata/pata_marvell.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c
index ae9feb1..6a543b9 100644
--- a/drivers/ata/pata_marvell.c
+++ b/drivers/ata/pata_marvell.c
@@ -175,6 +175,7 @@ static struct pci_driver marvell_pci_driver = {
.suspend = ata_pci_device_suspend,
.resume = ata_pci_device_resume,
#endif
+ .driver.async_probe = true,
};
module_pci_driver(marvell_pci_driver);
--
2.0.3
next parent reply other threads:[~2014-09-05 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409899047-13045-1-git-send-email-mcgrof@do-not-panic.com>
2014-09-05 6:37 ` Luis R. Rodriguez [this message]
2014-09-05 6:59 ` [RFC v2 6/6] pata_marvell: use async probe Alexander E. Patrakov
2014-09-05 7:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409899047-13045-7-git-send-email-mcgrof@do-not-panic.com \
--to=mcgrof@do-not-panic.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=falcon@meizu.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=joseph.salisbury@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=oleg@redhat.com \
--cc=patrakov@gmail.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=santosh@chelsio.com \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).