From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: [PATCH 33/38] libata: use __scsi_print_command() Date: Mon, 29 Sep 2014 13:59:02 +0200 Message-ID: <1411991947-130166-34-git-send-email-hare@suse.de> References: <1411991947-130166-1-git-send-email-hare@suse.de> Return-path: In-Reply-To: <1411991947-130166-1-git-send-email-hare@suse.de> Sender: linux-scsi-owner@vger.kernel.org To: James Bottomley Cc: Christoph Hellwig , linux-scsi@vger.kernel.org, Robert Elliott , Hannes Reinecke , Tejun Heo , linux-ide@vger.kernel.org, LKML List-Id: linux-ide@vger.kernel.org libata already uses an internal buffer, so we should be using __scsi_print_command() here. Cc: Tejun Heo Cc: linux-ide@vger.kernel.org Cc: LKML Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index dad83df..74c5652 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2509,15 +2509,11 @@ static void ata_eh_link_report(struct ata_link *link) if (ata_is_atapi(qc->tf.protocol)) { if (qc->scsicmd) - scsi_print_command(qc->scsicmd); + __scsi_print_command(cdb_buf, sizeof(cdb_buf), + qc->scsicmd->cmnd); else - snprintf(cdb_buf, sizeof(cdb_buf), - "cdb %02x %02x %02x %02x %02x %02x %02x %02x " - "%02x %02x %02x %02x %02x %02x %02x %02x\n ", - cdb[0], cdb[1], cdb[2], cdb[3], - cdb[4], cdb[5], cdb[6], cdb[7], - cdb[8], cdb[9], cdb[10], cdb[11], - cdb[12], cdb[13], cdb[14], cdb[15]); + __scsi_print_command(cdb_buf, sizeof(cdb_buf), + (unsigned char *)cdb); } else { const char *descr = ata_get_cmd_descript(cmd->command); if (descr) -- 1.8.5.2