Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

[Luben Tuikov <ltuikov@yahoo.com>]

--- Douglas Gilbert <dougg@torque.net> wrote:
> 
> I seem to be fighting a losing battle against the mindset

That may be the case.

> It is the _transport_ that should block the command,
> if it so chooses. In this case the transport is a
> virtual one between sr/sg and libata and libata should
> recognize SCSI ATA PASS-THROUGH (12+16) cdbs as
> transport related and not (directly) to be sent to
> the logical unit. And it is at this level we should
> add the wrinkle that if the pdt=5 (cd or dvd) then
> don't translate ATA_12. [I have already been around this
> loop with Luben and his SATL: sorted with the minimum
> of fuss.]

LOL, I don't think your mentioning my name in an email
to bottomley is going to convince him of anything, in
fact it may prompt him to do it the opposite way.

Good luck!

As to the "been around this loop", the fix was a two
liner, without checking the PDT, and ATA_16, ATA_12
and BLANK work as expected.

> ** I have been told that USB disk enclosures being designed
> now will include at a SATL. This will mean smartmontools

Absolutely.  Many reasons, one of which is having to deal
with battles like this one, probably the least one, but
still a reason which is sometimes mentioned.

    Luben