From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: [PATCH 04/10] libata: use __scsi_format_command() Date: Tue, 4 Nov 2014 09:06:43 +0100 Message-ID: <1415088409-46590-5-git-send-email-hare@suse.de> References: <1415088409-46590-1-git-send-email-hare@suse.de> Return-path: In-Reply-To: <1415088409-46590-1-git-send-email-hare@suse.de> Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley Cc: Christoph Hellwig , Ewan Milne , Robert Elliott , linux-scsi@vger.kernel.org, Hannes Reinecke , linux-ide@vger.kernel.org, LKML List-Id: linux-ide@vger.kernel.org libata already uses an internal buffer, so we should be using __scsi_format_command() here. Cc: linux-ide@vger.kernel.org Cc: LKML Acked-by: Tejun Heo Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index dad83df..6550a9a 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2509,15 +2509,12 @@ static void ata_eh_link_report(struct ata_link *link) if (ata_is_atapi(qc->tf.protocol)) { if (qc->scsicmd) - scsi_print_command(qc->scsicmd); + __scsi_format_command(cdb_buf, sizeof(cdb_buf), + qc->scsicmd->cmnd, + qc->scsicmd->cmd_len); else - snprintf(cdb_buf, sizeof(cdb_buf), - "cdb %02x %02x %02x %02x %02x %02x %02x %02x " - "%02x %02x %02x %02x %02x %02x %02x %02x\n ", - cdb[0], cdb[1], cdb[2], cdb[3], - cdb[4], cdb[5], cdb[6], cdb[7], - cdb[8], cdb[9], cdb[10], cdb[11], - cdb[12], cdb[13], cdb[14], cdb[15]); + __scsi_format_command(cdb_buf, sizeof(cdb_buf), + cdb, qc->dev->cdb_len); } else { const char *descr = ata_get_cmd_descript(cmd->command); if (descr) -- 1.8.5.2