linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Whitelist SSDs that are known to properly return zeroes after TRIM
Date: Wed, 10 Dec 2014 07:09:38 +0300	[thread overview]
Message-ID: <1418184578.2121.3.camel@HansenPartnership.com> (raw)
In-Reply-To: <20141205145148.GI4080@htj.dyndns.org>

On Fri, 2014-12-05 at 09:51 -0500, Tejun Heo wrote:
> > I just feel bad about disabling the feature for the many existing users
> > (and there are quite a few) that are using well-behaved drives in their
> > RAID deployments. And the filesystem folks have been begging for the
> > zeroout discard variant that I posted a few weeks ago. So the users are
> > there. I'm just trying to accommodate them the best I can given the lame
> > spec.
> 
> Can you please explain further the practical gains of using trims

It's for RAID devices.  We'd like to trim RAID devices simply by sending
the trim down to every component.  If we actually have to translate trim
to a write it would damage performance (and defeat the purpose of
helping the SSD FTL reuse blocks).  However, RAID requires that the
redundancy verification of the array components matches otherwise a
verify of the RAID fails.  This means we have to have a guarantee what
the verify read of a trimmed block of a RAID component will return.  So
for RAID-1, we just need both trimmed components to return the same data
(we don't actually care what it is, just that it be mirrored); for
RAID-5 we need zeros on every trimmed component, because zero^zero =
zero.

Conversely, drives that return random junk after a trim cause
verification failures, so we just elect not to transmit trim down to
them from the RAID layer.

James



  reply	other threads:[~2014-12-10  4:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  2:44 [PATCH] libata: Whitelist SSDs that are known to properly return zeroes after TRIM Martin K. Petersen
2014-12-04  3:02 ` Phillip Susi
2014-12-04  3:24   ` Martin K. Petersen
2014-12-04  3:28     ` Phillip Susi
2014-12-04  3:35       ` Martin K. Petersen
2014-12-04  4:40         ` Phillip Susi
2014-12-05  1:53           ` Martin K. Petersen
2014-12-04 21:49         ` One Thousand Gnomes
2014-12-05  2:46           ` Martin K. Petersen
2014-12-04 17:06 ` Tejun Heo
2014-12-05  2:13   ` Martin K. Petersen
2014-12-05 14:51     ` Tejun Heo
2014-12-10  4:09       ` James Bottomley [this message]
2014-12-10 14:29         ` Tejun Heo
2014-12-10 20:34           ` James Bottomley
2014-12-10 21:02           ` Martin K. Petersen
2014-12-12  8:35             ` Ming Lei
2015-01-05 16:28             ` Tejun Heo
2015-01-07  0:05               ` Martin K. Petersen
2015-01-07  2:54                 ` Tejun Heo
2015-01-07  4:15                   ` Dave Chinner
2015-01-07 15:26                     ` Tejun Heo
2015-01-08 14:28                       ` Martin K. Petersen
2015-01-08 15:11                         ` Tejun Heo
2015-01-08 15:34                           ` Martin K. Petersen
2015-01-08 15:36                             ` Tejun Heo
2015-01-08 15:58                         ` Tim Small
2015-01-09 20:52                           ` Martin K. Petersen
2015-01-09 21:39                             ` Tejun Heo
2015-01-08 14:29                       ` Martin K. Petersen
2015-01-08  4:05                     ` Phillip Susi
2015-01-08  4:58                       ` Andreas Dilger
2015-01-08 14:09                         ` Phillip Susi
2015-01-08 22:31                           ` Andreas Dilger
2014-12-10 15:43         ` Tim Small

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418184578.2121.3.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).