* [PATCH v1] libata: export ata_get_cmd_descript()
@ 2014-12-12 15:16 Andy Shevchenko
2014-12-12 17:25 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2014-12-12 15:16 UTC (permalink / raw)
To: Tejun Heo, linux-kernel, linux-ide; +Cc: Andy Shevchenko
The driver sata_dwc_460ex is using this symbol. To build it as a module we have
to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/ata/libata-eh.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 3dbec89..74fef87 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
return NULL;
}
+EXPORT_SYMBOL(ata_get_cmd_descript);
/**
* ata_eh_link_report - report error handling to user
--
2.1.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] libata: export ata_get_cmd_descript()
2014-12-12 15:16 [PATCH v1] libata: export ata_get_cmd_descript() Andy Shevchenko
@ 2014-12-12 17:25 ` Sergei Shtylyov
2014-12-12 17:35 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2014-12-12 17:25 UTC (permalink / raw)
To: Andy Shevchenko, Tejun Heo, linux-kernel, linux-ide
Hello.
On 12/12/2014 06:16 PM, Andy Shevchenko wrote:
> The driver sata_dwc_460ex is using this symbol. To build it as a module we have
> to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/ata/libata-eh.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 3dbec89..74fef87 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
>
> return NULL;
> }
> +EXPORT_SYMBOL(ata_get_cmd_descript);
Why not EXPORT_SYMBOL_GPL()?
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] libata: export ata_get_cmd_descript()
2014-12-12 17:25 ` Sergei Shtylyov
@ 2014-12-12 17:35 ` Andy Shevchenko
2015-01-05 16:21 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2014-12-12 17:35 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Tejun Heo, linux-kernel, linux-ide
On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/12/2014 06:16 PM, Andy Shevchenko wrote:
>
> > The driver sata_dwc_460ex is using this symbol. To build it as a module we have
> > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that.
>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/ata/libata-eh.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> > index 3dbec89..74fef87 100644
> > --- a/drivers/ata/libata-eh.c
> > +++ b/drivers/ata/libata-eh.c
> > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
> >
> > return NULL;
> > }
> > +EXPORT_SYMBOL(ata_get_cmd_descript);
>
> Why not EXPORT_SYMBOL_GPL()?
Some of the symbols are exported in that way. I think better to wait the
maintainer to tell which is preferred there.
>
> MBR, Sergei
>
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] libata: export ata_get_cmd_descript()
2014-12-12 17:35 ` Andy Shevchenko
@ 2015-01-05 16:21 ` Tejun Heo
2015-01-05 17:44 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2015-01-05 16:21 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Sergei Shtylyov, linux-kernel, linux-ide
On Fri, Dec 12, 2014 at 07:35:47PM +0200, Andy Shevchenko wrote:
> On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 12/12/2014 06:16 PM, Andy Shevchenko wrote:
> >
> > > The driver sata_dwc_460ex is using this symbol. To build it as a module we have
> > > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that.
> >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/ata/libata-eh.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> > > index 3dbec89..74fef87 100644
> > > --- a/drivers/ata/libata-eh.c
> > > +++ b/drivers/ata/libata-eh.c
> > > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
> > >
> > > return NULL;
> > > }
> > > +EXPORT_SYMBOL(ata_get_cmd_descript);
> >
> > Why not EXPORT_SYMBOL_GPL()?
>
> Some of the symbols are exported in that way. I think better to wait the
> maintainer to tell which is preferred there.
I don't really care. As the sole user is an in-kernel module, I'm
gonna append _GPL for now.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] libata: export ata_get_cmd_descript()
2015-01-05 16:21 ` Tejun Heo
@ 2015-01-05 17:44 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2015-01-05 17:44 UTC (permalink / raw)
To: Tejun Heo; +Cc: Sergei Shtylyov, linux-kernel, linux-ide
On Mon, 2015-01-05 at 11:21 -0500, Tejun Heo wrote:
> On Fri, Dec 12, 2014 at 07:35:47PM +0200, Andy Shevchenko wrote:
> > On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote:
> > > Hello.
> > >
> > > On 12/12/2014 06:16 PM, Andy Shevchenko wrote:
> > >
> > > > The driver sata_dwc_460ex is using this symbol. To build it as a module we have
> > > > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that.
> > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > > > drivers/ata/libata-eh.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > >
> > > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> > > > index 3dbec89..74fef87 100644
> > > > --- a/drivers/ata/libata-eh.c
> > > > +++ b/drivers/ata/libata-eh.c
> > > > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
> > > >
> > > > return NULL;
> > > > }
> > > > +EXPORT_SYMBOL(ata_get_cmd_descript);
> > >
> > > Why not EXPORT_SYMBOL_GPL()?
> >
> > Some of the symbols are exported in that way. I think better to wait the
> > maintainer to tell which is preferred there.
>
> I don't really care. As the sole user is an in-kernel module, I'm
> gonna append _GPL for now.
>
I'm okay with GPL. Thanks!
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-05 17:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-12 15:16 [PATCH v1] libata: export ata_get_cmd_descript() Andy Shevchenko
2014-12-12 17:25 ` Sergei Shtylyov
2014-12-12 17:35 ` Andy Shevchenko
2015-01-05 16:21 ` Tejun Heo
2015-01-05 17:44 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).