From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1] libata: export ata_get_cmd_descript() Date: Mon, 05 Jan 2015 19:44:45 +0200 Message-ID: <1420479885.12456.21.camel@linux.intel.com> References: <1418397391-13668-1-git-send-email-andriy.shevchenko@linux.intel.com> <548B2524.9050806@cogentembedded.com> <1418405747.17201.64.camel@linux.intel.com> <20150105162145.GO15833@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150105162145.GO15833@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org To: Tejun Heo Cc: Sergei Shtylyov , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org List-Id: linux-ide@vger.kernel.org On Mon, 2015-01-05 at 11:21 -0500, Tejun Heo wrote: > On Fri, Dec 12, 2014 at 07:35:47PM +0200, Andy Shevchenko wrote: > > On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 12/12/2014 06:16 PM, Andy Shevchenko wrote: > > > > > > > The driver sata_dwc_460ex is using this symbol. To build it as a module we have > > > > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that. > > > > > > > Signed-off-by: Andy Shevchenko > > > > --- > > > > drivers/ata/libata-eh.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > > > > index 3dbec89..74fef87 100644 > > > > --- a/drivers/ata/libata-eh.c > > > > +++ b/drivers/ata/libata-eh.c > > > > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command) > > > > > > > > return NULL; > > > > } > > > > +EXPORT_SYMBOL(ata_get_cmd_descript); > > > > > > Why not EXPORT_SYMBOL_GPL()? > > > > Some of the symbols are exported in that way. I think better to wait the > > maintainer to tell which is preferred there. > > I don't really care. As the sole user is an in-kernel module, I'm > gonna append _GPL for now. > I'm okay with GPL. Thanks! -- Andy Shevchenko Intel Finland Oy