From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Dolev Raviv <draviv@codeaurora.org>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Subhash Jadavani <subhashj@codeaurora.org>,
Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
"David S. Miller" <davem@davemloft.net>,
Hannes Reinecke <hare@suse.de>, Tejun Heo <tj@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mike Christie <michaelc@cs.wisc.edu>,
Karen Xie <kxie@chelsio.com>,
Robert Love <robert.w.love@intel.com>,
Christoph Hellwig <hch@lst.de>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
open-iscsi@googlegroups.com, fcoe-devel@open-fcoe.org,
linux-ide@vger.kernel.org, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net
Subject: [PATCH v4 00/11] scsi: fix module reference mismatch for scsi host
Date: Mon, 19 Jan 2015 00:05:58 +0900 [thread overview]
Message-ID: <1421593569-5089-1-git-send-email-akinobu.mita@gmail.com> (raw)
While accessing a scsi_device, the use count of the underlying LLDD
module is incremented. The module reference is retrieved through
.module field of struct scsi_host_template.
This mapping between scsi_device and underlying LLDD module works well
except some drivers which consist with the core driver and the actual
LLDDs and scsi_host_template is defined in the core driver. In these
cases, the actual LLDDs can be unloaded even if the scsi_device is
being accessed.
This patch series fixes the module reference mismatch problem for
ufs, usb-storage, esp_scsi, ahci_platform, and pata_platform drivers
by moving owner module reference field from struct scsi_host_template
to struct Scsi_Host and allowing the LLDDs to set their correct module
reference.
* v4:
- Patch series is almost rewritten as module reference field in
struct scsi_host_template has been unused anymore. So Acked-by: and
Reviewed-by: tags that have been received are deleted.
* v3:
- Add fix for ESP SCSI drivers
* v2:
- Pass correct module reference to usb_stor_probe1() instead of touching
all ums-* drivers, suggested by Alan Stern
Akinobu Mita (11):
ata: prepare to move module reference from scsi_host_template to
Scsi_Host
iscsi: prepare to move module reference from scsi_host_template to
Scsi_Host
cxgbi: prepare to move module reference from scsi_host_template to
Scsi_Host
libfc: prepare to move module reference from scsi_host_template to
Scsi_Host
53c700: prepare move module reference from scsi_host_template to
Scsi_Host
scsi: legacy: prepare to move module reference from scsi_host_template
to Scsi_Host
scsi: move module reference from scsi_host_template to Scsi_Host
scsi: ufs: adjust module reference for scsi host
usb: storage: adjust module reference for scsi host
ata: ahci_platform: adjust module reference for scsi host
ata: pata_of_platform: adjust module reference for scsi host
drivers/ata/libahci_platform.c | 14 +++++-----
drivers/ata/libata-core.c | 22 ++++++++-------
drivers/ata/libata-scsi.c | 2 +-
drivers/ata/libata-sff.c | 61 +++++++++++++++++++++++-------------------
drivers/ata/pata_platform.c | 18 +++++++------
drivers/scsi/53c700.c | 9 ++++---
drivers/scsi/53c700.h | 7 +++--
drivers/scsi/cxgbi/libcxgbi.c | 8 +++---
drivers/scsi/cxgbi/libcxgbi.h | 6 +++--
drivers/scsi/hosts.c | 16 ++++++-----
drivers/scsi/libfc/fc_lport.c | 26 ++++++++++++++++++
drivers/scsi/libfc/fc_npiv.c | 2 +-
drivers/scsi/libiscsi.c | 12 +++++----
drivers/scsi/scsi.c | 4 +--
drivers/scsi/ufs/ufshcd.c | 13 ++++-----
drivers/scsi/ufs/ufshcd.h | 5 +++-
drivers/usb/storage/scsiglue.c | 3 ---
drivers/usb/storage/usb.c | 9 ++++---
drivers/usb/storage/usb.h | 7 +++--
include/linux/ahci_platform.h | 9 ++++---
include/linux/ata_platform.h | 16 ++++++-----
include/linux/libata.h | 52 ++++++++++++++++++++++++-----------
include/scsi/libfc.h | 27 +++----------------
include/scsi/libiscsi.h | 9 ++++---
include/scsi/scsi_host.h | 13 +++++++--
25 files changed, 224 insertions(+), 146 deletions(-)
Cc: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: Dolev Raviv <draviv@codeaurora.org>
Cc: Sujit Reddy Thumma <sthumma@codeaurora.org>
Cc: Subhash Jadavani <subhashj@codeaurora.org>
Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Tejun Heo <tj@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>
Cc: Karen Xie <kxie@chelsio.com>
Cc: Robert Love <robert.w.love@intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: open-iscsi@googlegroups.com
Cc: fcoe-devel@open-fcoe.org
Cc: linux-ide@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: usb-storage@lists.one-eyed-alien.net
Cc: linux-scsi@vger.kernel.org
--
1.9.1
next reply other threads:[~2015-01-18 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 15:05 Akinobu Mita [this message]
2015-01-18 15:05 ` [PATCH v4 01/11] ata: prepare to move module reference from scsi_host_template to Scsi_Host Akinobu Mita
2015-01-18 15:06 ` [PATCH v4 07/11] scsi: " Akinobu Mita
2015-01-18 15:06 ` [PATCH v4 10/11] ata: ahci_platform: adjust module reference for scsi host Akinobu Mita
2015-01-18 15:30 ` Hans de Goede
2015-01-18 15:06 ` [PATCH v4 11/11] ata: pata_of_platform: " Akinobu Mita
2015-01-19 14:22 ` [PATCH v4 00/11] scsi: fix module reference mismatch " Tejun Heo
[not found] ` <20150119142206.GE8140-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2015-01-20 14:57 ` Akinobu Mita
2015-01-20 15:18 ` Tejun Heo
2015-01-20 15:20 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1501201013440.1150-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2015-01-22 13:17 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421593569-5089-1-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=JBottomley@parallels.com \
--cc=davem@davemloft.net \
--cc=draviv@codeaurora.org \
--cc=fcoe-devel@open-fcoe.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=kxie@chelsio.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
--cc=robert.w.love@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=sthumma@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=tj@kernel.org \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).