* [patch] sata_dwc_460ex: indent an if statement
@ 2015-03-30 10:30 Dan Carpenter
2015-03-30 10:59 ` Andy Shevchenko
2015-03-30 17:17 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-03-30 10:30 UTC (permalink / raw)
To: Tejun Heo, Andy Shevchenko; +Cc: linux-ide, kernel-janitors
We shuffled some code around in 8b3444852a2b ('sata_dwc_460ex: move to
generic DMA driver') an accidentally deleted a tab character here. It
causes a Smatch warning "if statement not indented".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 5ab4849..9020349 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -295,7 +295,7 @@ static void dma_dwc_xfer_done(void *hsdev_instance)
}
if ((hsdevp->dma_interrupt_count % 2) == 0)
- sata_dwc_dma_xfer_complete(ap, 1);
+ sata_dwc_dma_xfer_complete(ap, 1);
spin_unlock_irqrestore(&host->lock, flags);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] sata_dwc_460ex: indent an if statement
2015-03-30 10:30 [patch] sata_dwc_460ex: indent an if statement Dan Carpenter
@ 2015-03-30 10:59 ` Andy Shevchenko
2015-03-30 17:17 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2015-03-30 10:59 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Tejun Heo, linux-ide, kernel-janitors
On Mon, 2015-03-30 at 13:30 +0300, Dan Carpenter wrote:
> We shuffled some code around in 8b3444852a2b ('sata_dwc_460ex: move to
> generic DMA driver') an accidentally deleted a tab character here. It
> causes a Smatch warning "if statement not indented".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 5ab4849..9020349 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -295,7 +295,7 @@ static void dma_dwc_xfer_done(void *hsdev_instance)
> }
>
> if ((hsdevp->dma_interrupt_count % 2) == 0)
> - sata_dwc_dma_xfer_complete(ap, 1);
> + sata_dwc_dma_xfer_complete(ap, 1);
>
> spin_unlock_irqrestore(&host->lock, flags);
> }
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] sata_dwc_460ex: indent an if statement
2015-03-30 10:30 [patch] sata_dwc_460ex: indent an if statement Dan Carpenter
2015-03-30 10:59 ` Andy Shevchenko
@ 2015-03-30 17:17 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2015-03-30 17:17 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Andy Shevchenko, linux-ide, kernel-janitors
On Mon, Mar 30, 2015 at 01:30:25PM +0300, Dan Carpenter wrote:
> We shuffled some code around in 8b3444852a2b ('sata_dwc_460ex: move to
> generic DMA driver') an accidentally deleted a tab character here. It
> causes a Smatch warning "if statement not indented".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to libata/for-4.1.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-30 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 10:30 [patch] sata_dwc_460ex: indent an if statement Dan Carpenter
2015-03-30 10:59 ` Andy Shevchenko
2015-03-30 17:17 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).