Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Mikko Korhonen <mjkorhon@gmail.com>,
	Niklas Cassel <cassel@kernel.org>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: ahci: Disallow LPM for Asus B550-F motherboard
Date: Tue, 17 Jun 2025 15:32:17 +0900	[thread overview]
Message-ID: <14325a6a-6f95-4767-bcbd-cb9b735e8b37@kernel.org> (raw)
In-Reply-To: <20250617062055.784827-1-mjkorhon@gmail.com>

On 6/17/25 3:18 PM, Mikko Korhonen wrote:
> Asus ROG STRIX B550-F GAMING (WI-FI) motherboard has problems on some
> SATA ports with at least one hard drive model (WDC WD20EFAX-68FB5N0)
> when LPM is enabled. Disabling LPM solves the issue.
> 
> Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
> ---
> I think we might include the comment about the non working drive model, as
> we have tested only one model and in principle this could also be an
> interoperation issue. If one would need to enable LPM for the motherboard
> and happens to have a working hard drive model, he/she would know
> why we have made the patch in the first place.
> 
>  drivers/ata/ahci.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index c8ad8ace7496..ae8c4072a5a3 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1454,6 +1454,22 @@ static bool ahci_broken_lpm(struct pci_dev *pdev)
>  			},
>  			/* 320 is broken, there is no known good version yet. */
>  		},
> +		{
> +			/*
> +			 * AMD 500 Series Chipset SATA Controller [1022:43eb]
> +			 * on this motherboard timouts on ports 5 and 6
> +			 * when LPM enabled at least with WDC WD20EFAX-68FB5N0
> +			 * hard drives.
> +			 */
> +			.matches = {
> +				DMI_MATCH(DMI_BOARD_VENDOR,
> +					"ASUSTeK COMPUTER INC."),
> +				DMI_MATCH(DMI_BOARD_NAME,
> +					"ROG STRIX B550-F GAMING (WI-FI)"),
> +			},
> +			/* 3621 is broken, there is no known good version yet.
> +			 */

Please use the correct comment format:

			/*
			 * 3621 is broken and there is no known good version.
			 */

> +		},
>  		{ }	/* terminate list */
>  	};
>  	const struct dmi_system_id *dmi = dmi_first_match(sysids);


-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2025-06-17  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17  6:18 [PATCH] ata: ahci: Disallow LPM for Asus B550-F motherboard Mikko Korhonen
2025-06-17  6:32 ` Damien Le Moal [this message]
2025-06-17  8:52   ` Niklas Cassel
2025-06-17  9:14 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14325a6a-6f95-4767-bcbd-cb9b735e8b37@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mjkorhon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox