From: Joe Perches <joe@perches.com>
To: Tomer Barletz <barletz@gmail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
tj@kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Check return code from pdc20621_i2c_read()
Date: Sun, 02 Aug 2015 11:03:43 -0700 [thread overview]
Message-ID: <1438538623.1301.29.camel@perches.com> (raw)
In-Reply-To: <CAO-S75DznUxvYg9RPcDOaw1H8XK8MuXxFGOARVt-5OtW2_RJnA@mail.gmail.com>
On Sun, 2015-08-02 at 10:55 -0700, Tomer Barletz wrote:
> Re-sending in plain-text.
>
> On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
>
> > Please use pr_err() instead. And "0x%d" makes no sense at all,
> > please use "%#x" instead.
> >
>
> Yeah, not sure what I was drinking before writing this 0x%d thing...
>
> Regarding the pr_err() - it is not used at all in this file, and
> printk() is used instead. Wouldn't it be better to leave it with
> printk for this change, then have another change that replaces
> printk()s with pr_err()s?
Where possible, it'd be better to use ata_dev_<level>
next prev parent reply other threads:[~2015-08-02 18:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 10:12 [PATCH] Check return code from pdc20621_i2c_read() Tomer Barletz
2015-08-02 11:09 ` Sergei Shtylyov
[not found] ` <CAO-S75CRyh=FPbeTJMZWiYTvpd_wn57f4eGQgOHW2p16+9ANhQ@mail.gmail.com>
2015-08-02 17:55 ` Tomer Barletz
2015-08-02 18:03 ` Joe Perches [this message]
2015-08-02 20:22 ` Joe Perches
2015-08-03 15:42 ` Sergei Shtylyov
2015-08-03 15:52 ` Sergei Shtylyov
2015-08-03 18:46 ` [PATCH] sata_sx4: " Tomer Barletz
2015-08-03 18:52 ` Sergei Shtylyov
2015-08-03 19:04 ` Tomer Barletz
2015-08-03 19:09 ` Joe Perches
2015-08-03 19:19 ` Sergei Shtylyov
2015-08-03 19:18 ` Tomer Barletz
2015-08-06 16:40 ` Tejun Heo
2015-08-03 6:06 ` [PATCH] " Tomer Barletz
2015-08-03 15:40 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438538623.1301.29.camel@perches.com \
--to=joe@perches.com \
--cc=barletz@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).