[PATCH] ata: ahci: don't mark HotPlugCapable Ports as external/removable

[PATCH] ata: ahci: don't mark HotPlugCapable Ports as external/removable

[Manuel Lauss]

The HPCP bit is set by bioses for on-board sata ports either because
they think sata is hotplug capable in general or to allow Windows
to display a "device eject" icon on ports which are routed to an
external connector bracket.

However in Redhat Bugzilla #1310682, users report that with kernel 4.4,
where this bit test first appeared, a lot of partitions on sata drives
are now mounted automatically.

This patch should fix redhat and a lot of other distros which
unconditionally automount all devices which have the "removable"
bit set.

Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
 drivers/ata/libahci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 4029679..e029e3c 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1164,8 +1164,7 @@ static void ahci_port_init(struct device *dev, struct ata_port *ap,
 
 	/* mark esata ports */
 	tmp = readl(port_mmio + PORT_CMD);
-	if ((tmp & PORT_CMD_HPCP) ||
-	    ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS)))
+	if ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS))
 		ap->pflags |= ATA_PFLAG_EXTERNAL;
 }
 
-- 
2.7.2

Re: [PATCH] ata: ahci: don't mark HotPlugCapable Ports as external/removable

[Tejun Heo]

On Sat, Feb 27, 2016 at 04:10:05PM +0100, Manuel Lauss wrote:
> The HPCP bit is set by bioses for on-board sata ports either because
> they think sata is hotplug capable in general or to allow Windows
> to display a "device eject" icon on ports which are routed to an
> external connector bracket.
> 
> However in Redhat Bugzilla #1310682, users report that with kernel 4.4,
> where this bit test first appeared, a lot of partitions on sata drives
> are now mounted automatically.
> 
> This patch should fix redhat and a lot of other distros which
> unconditionally automount all devices which have the "removable"
> bit set.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>

Applied to libata/for-4.5-fixes w/ stable cc'd.

Thanks.

-- 
tejun