From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Damien Le Moal <Damien.LeMoal@hgst.com>, Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata-core: Allow longer timeout for drive spinup from PUIS
Date: Thu, 07 Apr 2016 07:00:23 -0400 [thread overview]
Message-ID: <1460026823.20949.2.camel@HansenPartnership.com> (raw)
In-Reply-To: <EA6FA468-118B-43C2-B6CE-2658650AE544@hgst.com>
On Thu, 2016-04-07 at 01:22 +0000, Damien Le Moal wrote:
> Tejun,
>
> > Applied to libata/for-4.7. Can you please use git format-patch to
> > generate the patch file from next time?
>
> Thanks !
> For the patch, I used “git show xxx > file”...
> Is this not correct ? Should I be using a “—pretty=xxx” formatting ?
If you want to use git show, then you need --pretty=email (depending on
whether you want to add the commit statistics, you can also add --stat
--patch).
If you have a patch series, it's often better to use
git-format-patch -n --cover-letter
Which generates a set of numbered files for the entire patch series.
James
next prev parent reply other threads:[~2016-04-07 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 8:22 [PATCH] libata-core: Allow longer timeout for drive spinup from PUIS Damien Le Moal
2016-03-30 18:38 ` Tejun Heo
2016-04-02 12:23 ` Damien Le Moal
2016-04-04 16:18 ` Tejun Heo
2016-04-07 1:22 ` Damien Le Moal
2016-04-07 11:00 ` James Bottomley [this message]
2016-04-07 17:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460026823.20949.2.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=Damien.LeMoal@hgst.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).