From: Wei Fang <fangwei1@huawei.com>
To: tj@kernel.org, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, corbet@lwn.net
Cc: hch@infradead.org, dan.j.williams@intel.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-doc@vger.kernel.org, Wei Fang <fangwei1@huawei.com>
Subject: [PATCH v2 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed
Date: Tue, 31 May 2016 16:38:18 +0800 [thread overview]
Message-ID: <1464683898-9877-2-git-send-email-fangwei1@huawei.com> (raw)
In-Reply-To: <1464683898-9877-1-git-send-email-fangwei1@huawei.com>
Update the new concurrency rules of ->host_failed.
Signed-off-by: Wei Fang <fangwei1@huawei.com>
---
Documentation/scsi/scsi_eh.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt
index 8638f61..e6d0de2 100644
--- a/Documentation/scsi/scsi_eh.txt
+++ b/Documentation/scsi/scsi_eh.txt
@@ -252,7 +252,7 @@ scmd->allowed.
- set scmd->eh_eflags
- add scmd to shost->eh_cmd_q
- set SHOST_RECOVERY
- - shost->host_failed++
+ - atomic_inc(&shost->host_failed)
LOCKING: shost->host_lock
2. EH starts
@@ -263,7 +263,7 @@ scmd->allowed.
3. scmd recovered
ACTION: scsi_eh_finish_cmd() is invoked to EH-finish scmd
- - shost->host_failed--
+ - atomic_dec(&shost->host_failed)
- clear scmd->eh_eflags
- scsi_setup_cmd_retry()
- move from local eh_work_q to local eh_done_q
--
1.7.1
next prev parent reply other threads:[~2016-05-31 8:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 8:38 [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed Wei Fang
2016-05-31 8:38 ` Wei Fang [this message]
2016-05-31 14:33 ` Tejun Heo
2016-06-01 1:20 ` Wei Fang
2016-06-01 3:21 ` Dan Williams
2016-06-01 3:30 ` Dan Williams
2016-06-01 14:06 ` James Bottomley
2016-06-02 1:58 ` Wei Fang
2016-06-01 14:36 ` Kevin Groeneveld
2016-06-01 15:29 ` Bart Van Assche
2016-06-01 15:38 ` James Bottomley
2016-06-02 2:37 ` Wei Fang
2016-06-02 3:09 ` Wei Fang
2016-06-06 12:48 ` Kevin Groeneveld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464683898-9877-2-git-send-email-fangwei1@huawei.com \
--to=fangwei1@huawei.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox