public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
	Kevin Groeneveld <KGroeneveld@lenbrook.com>,
	Wei Fang <fangwei1@huawei.com>, "tj@kernel.org" <tj@kernel.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"corbet@lwn.net" <corbet@lwn.net>
Cc: "hch@infradead.org" <hch@infradead.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed
Date: Wed, 01 Jun 2016 11:38:54 -0400	[thread overview]
Message-ID: <1464795534.23285.4.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <38efc40d-fec9-3278-abb8-2a78c4146a8c@sandisk.com>

On Wed, 2016-06-01 at 08:29 -0700, Bart Van Assche wrote:
> On 06/01/2016 07:36 AM, Kevin Groeneveld wrote:
> > > Subject: [PATCH v2 1/2] scsi: fix race between simultaneous
> > > decrements of ->host_failed
> > 
> > I wonder if this could be related to 
> > http://www.spinics.net/lists/linux-scsi/msg86808.html?
> > 
> > I never did get to the bottom of that.  If I have time I hope to
> > retest my scsi hang issue with this patch.
> 
> I've never seen that hang with the ib_srp driver (which is a SCSI 
> LLD). That probably means that the SATA code uses the SCSI error 
> handler in another way than other SCSI LLDs.

It's the ata_sas error handler, which is split between libsas and
libata.  It does one thread of execution per ata port when the strategy
handler is invoked.  This behaviour is pretty much unique at the
moment.

James



  reply	other threads:[~2016-06-01 15:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  8:38 [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed Wei Fang
2016-05-31  8:38 ` [PATCH v2 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed Wei Fang
2016-05-31 14:33 ` [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed Tejun Heo
2016-06-01  1:20   ` Wei Fang
2016-06-01  3:21 ` Dan Williams
2016-06-01  3:30   ` Dan Williams
2016-06-01 14:06 ` James Bottomley
2016-06-02  1:58   ` Wei Fang
2016-06-01 14:36 ` Kevin Groeneveld
2016-06-01 15:29   ` Bart Van Assche
2016-06-01 15:38     ` James Bottomley [this message]
2016-06-02  2:37   ` Wei Fang
2016-06-02  3:09     ` Wei Fang
2016-06-06 12:48     ` Kevin Groeneveld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464795534.23285.4.camel@linux.vnet.ibm.com \
    --to=jejb@linux.vnet.ibm.com \
    --cc=KGroeneveld@lenbrook.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=fangwei1@huawei.com \
    --cc=hch@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox