From: Wei Fang <fangwei1@huawei.com>
To: tj@kernel.org, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, corbet@lwn.net
Cc: hch@infradead.org, dan.j.williams@intel.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-doc@vger.kernel.org, Wei Fang <fangwei1@huawei.com>
Subject: [PATCH v4 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed
Date: Tue, 7 Jun 2016 14:53:57 +0800 [thread overview]
Message-ID: <1465282437-10653-2-git-send-email-fangwei1@huawei.com> (raw)
In-Reply-To: <1465282437-10653-1-git-send-email-fangwei1@huawei.com>
Update the new concurrency rules of ->host_failed.
Signed-off-by: Wei Fang <fangwei1@huawei.com>
---
Documentation/scsi/scsi_eh.txt | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt
index 8638f61..37eca00 100644
--- a/Documentation/scsi/scsi_eh.txt
+++ b/Documentation/scsi/scsi_eh.txt
@@ -263,19 +263,23 @@ scmd->allowed.
3. scmd recovered
ACTION: scsi_eh_finish_cmd() is invoked to EH-finish scmd
- - shost->host_failed--
- clear scmd->eh_eflags
- scsi_setup_cmd_retry()
- move from local eh_work_q to local eh_done_q
LOCKING: none
+ CONCURRENCY: at most one thread per separate eh_work_q to
+ keep queue manipulation lockless
4. EH completes
ACTION: scsi_eh_flush_done_q() retries scmds or notifies upper
- layer of failure.
+ layer of failure. May be called concurrently but must have
+ a no more than one thread per separate eh_work_q to
+ manipulate the queue locklessly
- scmd is removed from eh_done_q and scmd->eh_entry is cleared
- if retry is necessary, scmd is requeued using
scsi_queue_insert()
- otherwise, scsi_finish_command() is invoked for scmd
+ - zero shost->host_failed
LOCKING: queue or finish function performs appropriate locking
--
1.7.1
next prev parent reply other threads:[~2016-06-07 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 6:53 [PATCH v4 1/2] scsi: fix race between simultaneous decrements of ->host_failed Wei Fang
2016-06-07 6:53 ` Wei Fang [this message]
2016-06-09 3:11 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465282437-10653-2-git-send-email-fangwei1@huawei.com \
--to=fangwei1@huawei.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).