From: <yuantian.tang@nxp.com>
To: tj@kernel.org, linux-ide@vger.kernel.org
Cc: Tang Yuantian <Yuantian.Tang@nxp.com>,
Tang Yuantian <yuantian.tang@nxp.com>
Subject: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
Date: Wed, 28 Sep 2016 09:46:12 +0800 [thread overview]
Message-ID: <1475027172-21012-1-git-send-email-yuantian.tang@nxp.com> (raw)
From: Tang Yuantian <Yuantian.Tang@nxp.com>
This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ
on ls2080a SoC")
The erratum has been fixed in ls2080a v2.0 and later soc.
Since ls2080a v1.0 has rarely been released, it can be safely
reverted.
Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
---
drivers/ata/ahci_qoriq.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index 7bdee9b..2342fca 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -137,7 +137,7 @@ static struct ata_port_operations ahci_qoriq_ops = {
.hardreset = ahci_qoriq_hardreset,
};
-static struct ata_port_info ahci_qoriq_port_info = {
+static const struct ata_port_info ahci_qoriq_port_info = {
.flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
.pio_mask = ATA_PIO4,
.udma_mask = ATA_UDMA6,
@@ -221,12 +221,6 @@ static int ahci_qoriq_probe(struct platform_device *pdev)
if (rc)
goto disable_resources;
- /* Workaround for ls2080a */
- if (qoriq_priv->type == AHCI_LS2080A) {
- hpriv->flags |= AHCI_HFLAG_NO_NCQ;
- ahci_qoriq_port_info.flags &= ~ATA_FLAG_NCQ;
- }
-
rc = ahci_platform_init_host(pdev, hpriv, &ahci_qoriq_port_info,
&ahci_qoriq_sht);
if (rc)
--
2.1.0.27.g96db324
next reply other threads:[~2016-09-28 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 1:46 yuantian.tang [this message]
2016-09-29 8:55 ` [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC" Tejun Heo
2016-09-29 9:07 ` Y.T. Tang
2016-09-29 9:58 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2016-09-30 6:12 yuantian.tang
2016-09-30 6:29 ` Y.T. Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475027172-21012-1-git-send-email-yuantian.tang@nxp.com \
--to=yuantian.tang@nxp.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).