From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Peter Chang <dpf@google.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] set a base index for libsas based ata devices
Date: Tue, 20 Dec 2016 10:30:34 -0800 [thread overview]
Message-ID: <1482258634.2475.20.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAF2xp_F3ea-n4R8jG8UpHEE3YmvKN7UWBAn36_QXMg-e34tY_w@mail.gmail.com>
On Tue, 2016-12-20 at 10:15 -0800, Peter Chang wrote:
> we discovered this when futzing w/ the queue depth parameter for ata
> disks behind the pm8006 controller. setting depth == 1 should disable
> ncq, but the sysfs part silently fails and we continue sending the
> fpdma command variants. no one else probably cares about the
> disabling ncq path, but we do like to test.
I'd actually disagree with this assertion; it's why tagging (what you
mean by ncq) and queue depth are separate. Queue depth represents the
number of outstanding commands we sent on the wire; however, it often
excludes things like sense probes and error handling commands, so
tagged depth==1 is a different operating environment from untagged.
Some transports actually have no untagged variant nowadays, so it's
physically impossible to disable tagging.
James
> anyway, adding both the ide and scsi lists because i'm not quite sure
> there's a separate libsas list and a single commit seems better for
> this.
next prev parent reply other threads:[~2016-12-20 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 18:15 [PATCH] set a base index for libsas based ata devices Peter Chang
2016-12-20 18:30 ` James Bottomley [this message]
2016-12-21 8:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482258634.2475.20.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dpf@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox