public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Tejun Heo <tj@kernel.org>, Jason Cooper <jason@lakedaemon.net>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] Revert "ata: sata_mv: Convert to devm_ioremap_resource()"
Date: Thu, 25 May 2017 16:34:26 +0300	[thread overview]
Message-ID: <1495719266.6967.120.camel@linux.intel.com> (raw)
In-Reply-To: <20170525132639.GK1788@lunn.ch>

On Thu, 2017-05-25 at 15:26 +0200, Andrew Lunn wrote:
> > > What issue? You are allowed to have overlapping memory resources.
> > 
> > Exactly, and then the question why did you do a revert?
> 
> Because we are at -rc2.

No, my point is that (repeating myself) revert just *hides* the actual
issue. 

Yes, I understand that it's a quick fix, and it should not be considered
as best solution.

>  We need a quick fix now, so that my NAS box
> disks start spinning again. You can then spend some time to consider a
> better fix, and get it merged in the 4.13 merge window.
> 

> Please feel free to Cc: me and the other Marvell maintainers on
> patches, so we can test them.

I'm not going to do that since I have no such issue, no possibility to
test and actually choose best strategy with your hardware.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-05-25 13:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 23:39 [PATCH] Revert "ata: sata_mv: Convert to devm_ioremap_resource()" Andrew Lunn
2017-05-24 13:01 ` Gregory CLEMENT
2017-05-24 13:12   ` Andrew Lunn
2017-05-24 13:36   ` Andy Shevchenko
2017-05-24 13:41     ` Andrew Lunn
2017-05-24 14:00       ` Andy Shevchenko
2017-05-24 14:11         ` Gregory CLEMENT
2017-05-24 14:29         ` Andrew Lunn
2017-05-25 12:53           ` Andy Shevchenko
2017-05-25 13:26             ` Andrew Lunn
2017-05-25 13:34               ` Andy Shevchenko [this message]
2017-05-24 15:07 ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2017-05-30 13:52 Linus Walleij
2017-05-30 13:55 ` Andy Shevchenko
2017-05-30 23:53   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495719266.6967.120.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andrew@lunn.ch \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox