From: Joe Perches <joe@perches.com>
To: Tejun Heo <tj@kernel.org>, Bhumika Goyal <bhumirks@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
b.zolnierkie@samsung.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: make ata_port_operations const
Date: Mon, 07 Aug 2017 09:34:12 -0700 [thread overview]
Message-ID: <1502123652.2219.24.camel@perches.com> (raw)
In-Reply-To: <20170807162920.GA537256@devbig577.frc2.facebook.com>
On Mon, 2017-08-07 at 09:29 -0700, Tejun Heo wrote:
> Hello,
>
> On Mon, Aug 07, 2017 at 08:54:21PM +0530, Bhumika Goyal wrote:
> > I compiled the .o files and checked the size before and after
> > compilation. After making the structure const, bytes should move from
> > data to text segment of the memory and this is what happened. So, this
> > is how I tested it.
>
> Ah, I see, so the port_operations is never used directly. I'm not
> sure whether it'd be a good idea to selectively pick these and makr
> them const. Let's just leave them be.
Why?
Things that are never accessed as other than const should
be const no?
Why leave unnecessary exposure for muckery?
next prev parent reply other threads:[~2017-08-07 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 10:32 [PATCH] ata: make ata_port_operations const Bhumika Goyal
2017-08-07 15:07 ` Tejun Heo
2017-08-07 15:24 ` Bhumika Goyal
2017-08-07 16:29 ` Tejun Heo
2017-08-07 16:34 ` Joe Perches [this message]
2017-08-08 8:11 ` Bhumika Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502123652.2219.24.camel@perches.com \
--to=joe@perches.com \
--cc=b.zolnierkie@samsung.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox