From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "arnd@arndb.de" <arnd@arndb.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV
Date: Thu, 2 Nov 2017 14:59:42 +0000 [thread overview]
Message-ID: <1509634781.2484.3.camel@wdc.com> (raw)
In-Reply-To: <20171102111952.4021454-1-arnd@arndb.de>
On Thu, 2017-11-02 at 12:19 +0100, Arnd Bergmann wrote:
> After the cdrom cleanup, I get randconfig warnings for some configurations:
>
> warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV)
Hello Arnd,
Since Jens has already queued your patch it's too late to consider alternatives.
Anyway, since the cdrom driver calls block layer functions directly, have you
considered the following alternative?
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 0dad1d2536f7..e7044c893817 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -69,6 +69,7 @@ config AMIGA_Z2RAM
config CDROM
tristate "CD-ROM driver"
+ depends on BLK_DEV
help
A CD-ROM is a pre-pressed optical compact disc which contains
data. The name is an acronym which stands for "Compact Disc
next prev parent reply other threads:[~2017-11-02 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:19 [PATCH] block: fix CDROM dependency on BLK_DEV Arnd Bergmann
2017-11-02 14:27 ` Jens Axboe
2017-11-02 15:01 ` Bart Van Assche
2017-11-02 15:11 ` Jens Axboe
2017-11-02 14:59 ` Bart Van Assche [this message]
2017-11-02 15:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509634781.2484.3.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox