From: Justin Maggard <jmaggard10@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Mark Lord <kernel@teksavvy.com>,
Robert Hancock <hancockrwd@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: Hotplug issue with Marvell 6121
Date: Thu, 11 Mar 2010 10:42:35 -0800 [thread overview]
Message-ID: <150c16851003111042r1ccc5e2bv3649f9817c36ad9a@mail.gmail.com> (raw)
In-Reply-To: <4B986745.305@kernel.org>
On Wed, Mar 10, 2010 at 7:45 PM, Tejun Heo <tj@kernel.org> wrote:
> On 03/11/2010 12:33 PM, Mark Lord wrote:
>> If it's like their non-AHCI controllers (sata_mv), then the chipset/phy
>> could be very particular about the sequence/timing used when changing
>> speeds.
This is certainly possible. The 6121 has a PATA port, and can be used
with the sata_mv driver also.
> BTW, if not allowing PHY speed adjustment is necessary, the correct
> way to implement that is in ->port_start() by modifying
> link->hw_sata_spd_limit. But I really hope there's some other way to
> solve this.
I assume you're talking about setting hw_sata_spd_limit to 1.5Gbps so
that sata_down_spd_limit() doesn't do anything? That will work, but
it would still be nice to be able to run at 3.0Gbps on these ports.
If anyone has any more elegant solutions they would like me to test,
just let me know.
Thanks,
-Justin
next prev parent reply other threads:[~2010-03-11 18:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 0:51 Hotplug issue with Marvell 6121 Justin Maggard
2010-03-10 22:46 ` Justin Maggard
2010-03-11 0:53 ` Robert Hancock
2010-03-11 1:01 ` Tejun Heo
2010-03-11 2:32 ` Justin Maggard
2010-03-11 3:33 ` Mark Lord
2010-03-11 3:45 ` Tejun Heo
2010-03-11 18:42 ` Justin Maggard [this message]
2010-03-11 22:28 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150c16851003111042r1ccc5e2bv3649f9817c36ad9a@mail.gmail.com \
--to=jmaggard10@gmail.com \
--cc=hancockrwd@gmail.com \
--cc=kernel@teksavvy.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).