From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error Date: Sat, 25 Nov 2017 03:02:24 -0800 Message-ID: <1511607744.2503.1.camel@perches.com> References: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:35047 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750935AbdKYLC2 (ORCPT ); Sat, 25 Nov 2017 06:02:28 -0500 In-Reply-To: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Arvind Yadav , b.zolnierkie@samsung.com, tj@kernel.org, sergei.shtylyov@cogentembedded.com Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] > diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] > @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device **r_failed > */ > static struct pdc2027x_pio_timing { > u8 value0, value1, value2; > -} pdc2027x_pio_timing_tbl [] = { > +} pdc2027x_pio_timing_tbl[] = { > { 0xfb, 0x2b, 0xac }, /* PIO mode 0 */ > { 0x46, 0x29, 0xa4 }, /* PIO mode 1 */ > { 0x23, 0x26, 0x64 }, /* PIO mode 2 */ trivia: It seems all the _timing_tbl structs should be const