* [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start()
@ 2018-02-15 21:22 SF Markus Elfring
2018-02-16 9:39 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2018-02-15 21:22 UTC (permalink / raw)
To: linux-ide, Tejun Heo; +Cc: LKML, kernel-janitors, Andy Shevchenko
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 15 Feb 2018 22:15:25 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/ata/sata_dwc_460ex.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 6af4ec3c88c3..ce3d6674ef80 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -901,7 +901,6 @@ static int sata_dwc_port_start(struct ata_port *ap)
/* Allocate Port Struct */
hsdevp = kzalloc(sizeof(*hsdevp), GFP_KERNEL);
if (!hsdevp) {
- dev_err(ap->dev, "%s: kmalloc failed for hsdevp\n", __func__);
err = -ENOMEM;
goto CLEANUP;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start()
2018-02-15 21:22 [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() SF Markus Elfring
@ 2018-02-16 9:39 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2018-02-16 9:39 UTC (permalink / raw)
To: SF Markus Elfring, linux-ide, Tejun Heo; +Cc: LKML, kernel-janitors
On Thu, 2018-02-15 at 22:22 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 15 Feb 2018 22:15:25 +0100
>
> Omit an extra message for a memory allocation failure in this
> function.
>
> This issue was detected by using the Coccinelle software.
Tejun, it's up to you. In case you are fine with the change,
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/ata/sata_dwc_460ex.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ata/sata_dwc_460ex.c
> b/drivers/ata/sata_dwc_460ex.c
> index 6af4ec3c88c3..ce3d6674ef80 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -901,7 +901,6 @@ static int sata_dwc_port_start(struct ata_port
> *ap)
> /* Allocate Port Struct */
> hsdevp = kzalloc(sizeof(*hsdevp), GFP_KERNEL);
> if (!hsdevp) {
> - dev_err(ap->dev, "%s: kmalloc failed for hsdevp\n",
> __func__);
> err = -ENOMEM;
> goto CLEANUP;
> }
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-16 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-15 21:22 [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start() SF Markus Elfring
2018-02-16 9:39 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).