* [PATCH 2/2] ide: pdc202xx_new: Replace mdelay with msleep in init_chipset_pdcnew
@ 2018-04-11 7:52 Jia-Ju Bai
0 siblings, 0 replies; only message in thread
From: Jia-Ju Bai @ 2018-04-11 7:52 UTC (permalink / raw)
To: davem, frankt, andre; +Cc: linux-ide, linux-kernel, Jia-Ju Bai
init_chipset_pdcnew() is never called in atomic context.
This function is only set as ".init_chipset" in struct ide_port_info.
Despite never getting called from atomic context, init_chipset_pdcnew()
calls mdelay() to busily wait.
This is not necessary and can be replaced with msleep() to
avoid busy waiting.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/ide/pdc202xx_new.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pdc202xx_new.c b/drivers/ide/pdc202xx_new.c
index b33646b..a654491 100644
--- a/drivers/ide/pdc202xx_new.c
+++ b/drivers/ide/pdc202xx_new.c
@@ -403,7 +403,7 @@ static int init_chipset_pdcnew(struct pci_dev *dev)
outb(pll_ctl1, sec_dma_base + 0x03);
/* Wait the PLL circuit to be stable */
- mdelay(30);
+ msleep(30);
#ifdef DEBUG
/*
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-11 7:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-11 7:52 [PATCH 2/2] ide: pdc202xx_new: Replace mdelay with msleep in init_chipset_pdcnew Jia-Ju Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).