From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Ondrej Zary <linux@zary.sk>
Cc: Christoph Hellwig <hch@lst.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>,
linux-block@vger.kernel.org, linux-parport@lists.infradead.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/block: Move PARIDE protocol modules to drivers/ata/pata_parport
Date: Tue, 31 Jan 2023 20:36:53 +0900 [thread overview]
Message-ID: <1569ffb1-b23c-3f8c-6467-102f51426850@opensource.wdc.com> (raw)
In-Reply-To: <202301311124.23302.linux@zary.sk>
On 1/31/23 19:24, Ondrej Zary wrote:
> On Tuesday 31 January 2023, Damien Le Moal wrote:
>> On 1/31/23 06:10, Ondrej Zary wrote:
>>> diff --git a/drivers/Makefile b/drivers/Makefile
>>> index f1365608bc8c..de8aa561c95c 100644
>>> --- a/drivers/Makefile
>>> +++ b/drivers/Makefile
>>> @@ -98,7 +98,7 @@ obj-$(CONFIG_DIO) += dio/
>>> obj-$(CONFIG_SBUS) += sbus/
>>> obj-$(CONFIG_ZORRO) += zorro/
>>> obj-$(CONFIG_ATA_OVER_ETH) += block/aoe/
>>> -obj-y += block/paride/
>>> +obj-$(CONFIG_PATA_PARPORT) += ata/pata_parport/
>>
>> It would be better to have this in drivers/ata/Makefile, not here, so that doing
>> something like:
>>
>> make -j64 M=drivers/ata W=1
>> or
>> make -j64 M=drivers/ata C=1
>>
>> actually also checks the parport protocol modules too.
>>
>> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
>> index 23588738cff0..2f85812e16ef 100644
>> --- a/drivers/ata/Makefile
>> +++ b/drivers/ata/Makefile
>> @@ -114,6 +114,7 @@ obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o
>>
>> obj-$(CONFIG_PATA_PXA) += pata_pxa.o
>>
>> +obj-$(CONFIG_PATA_PARPORT) += pata_parport/
>> obj-$(CONFIG_PATA_PARPORT) += pata_parport.o
>>
>> And then we could also have drivers/ata/pata_parport.c moved under
>> drivers/ata/pata_parport/ to tidy things up.
>>
>> If you agree, I can fix that up, that is easy to do.
>
> OK, thank you.
All queued now. Thanks !
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-01-31 11:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 22:53 [PATCH v2] pata_parport: add driver (PARIDE replacement) Ondrej Zary
2023-01-22 7:57 ` Christoph Hellwig
2023-01-22 18:14 ` [PATCH] paride: Mark PARIDE as deprecated, point to PATA_PARPORT Ondrej Zary
2023-01-22 19:11 ` Sergey Shtylyov
2023-01-22 20:10 ` [PATCH v2] " Ondrej Zary
2023-01-23 7:38 ` [PATCH] " Hannes Reinecke
2023-01-22 18:24 ` [PATCH v2] pata_parport: add driver (PARIDE replacement) Jens Axboe
2023-01-23 1:15 ` Damien Le Moal
2023-01-23 6:52 ` Christoph Hellwig
2023-01-23 14:05 ` Jens Axboe
2023-01-23 7:37 ` Hannes Reinecke
2023-01-23 1:03 ` Damien Le Moal
2023-01-23 19:09 ` [PATCH v3] " Ondrej Zary
2023-01-30 3:30 ` Damien Le Moal
2023-01-30 3:44 ` Jens Axboe
2023-01-30 6:48 ` Christoph Hellwig
2023-01-30 7:10 ` Damien Le Moal
2023-01-30 15:25 ` Jens Axboe
2023-01-30 23:18 ` Damien Le Moal
2023-01-30 15:24 ` Jens Axboe
2023-01-30 21:10 ` [PATCH 1/2] drivers/block: Remove PARIDE core and high-level protocols Ondrej Zary
2023-01-30 21:10 ` [PATCH 2/2] drivers/block: Move PARIDE protocol modules to drivers/ata/pata_parport Ondrej Zary
2023-01-30 23:24 ` Jens Axboe
2023-01-31 2:05 ` Damien Le Moal
2023-01-31 10:24 ` Ondrej Zary
2023-01-31 11:36 ` Damien Le Moal [this message]
2023-01-30 23:24 ` [PATCH 1/2] drivers/block: Remove PARIDE core and high-level protocols Jens Axboe
2023-01-23 19:13 ` [PATCH v2] pata_parport: add driver (PARIDE replacement) Ondrej Zary
2023-01-24 10:02 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569ffb1-b23c-3f8c-6467-102f51426850@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=s.shtylyov@omp.ru \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox