* [PATCH] libata: specify timeout value when internal command times out.
@ 2020-11-23 18:42 David Milburn
0 siblings, 0 replies; 4+ messages in thread
From: David Milburn @ 2020-11-23 18:42 UTC (permalink / raw)
To: linux-ide; +Cc: axboe
Specifying timeout value may help in troubleshooting failures.
Signed-off-by: David Milburn <dmilburn@redhat.com>
---
drivers/ata/libata-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 61c762961ca8..8f1ba6208e5c 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1600,8 +1600,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev,
ata_qc_complete(qc);
if (ata_msg_warn(ap))
- ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
- command);
+ ata_dev_warn(dev, "qc timeout after %lu msecs (cmd 0x%x)\n",
+ timeout, command);
}
spin_unlock_irqrestore(ap->lock, flags);
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] libata: specify timeout value when internal command times out.
@ 2022-07-26 17:01 Tomas Henzl
2022-07-26 17:36 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Tomas Henzl @ 2022-07-26 17:01 UTC (permalink / raw)
To: linux-ide
Specifying timeout value may help in troubleshooting failures.
Signed-off-by: David Milburn <dmilburn@redhat.com>
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/ata/libata-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 40e816419f48..e1f8a01a3b92 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1578,8 +1578,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev,
else
ata_qc_complete(qc);
- ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
- command);
+ ata_dev_warn(dev, "qc timeout after %lu msecs (cmd 0x%x)\n",
+ timeout, command);
}
spin_unlock_irqrestore(ap->lock, flags);
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: specify timeout value when internal command times out.
2022-07-26 17:01 Tomas Henzl
@ 2022-07-26 17:36 ` Sergei Shtylyov
2022-07-28 15:46 ` Tomas Henzl
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2022-07-26 17:36 UTC (permalink / raw)
To: Tomas Henzl, linux-ide
Hello!
On 7/26/22 8:01 PM, Tomas Henzl wrote:
> Specifying timeout value may help in troubleshooting failures.
>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
> drivers/ata/libata-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 40e816419f48..e1f8a01a3b92 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -1578,8 +1578,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev,
> else
> ata_qc_complete(qc);
>
> - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
> - command);
> + ata_dev_warn(dev, "qc timeout after %lu msecs (cmd 0x%x)\n",
> + timeout, command);
The 'timeout' parameter is now *unsigned int*, please generate the patches
against the libata repo's for-next branch.
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: specify timeout value when internal command times out.
2022-07-26 17:36 ` Sergei Shtylyov
@ 2022-07-28 15:46 ` Tomas Henzl
0 siblings, 0 replies; 4+ messages in thread
From: Tomas Henzl @ 2022-07-28 15:46 UTC (permalink / raw)
To: Sergei Shtylyov, linux-ide
On 7/26/22 19:36, Sergei Shtylyov wrote:
> Hello!
>
> On 7/26/22 8:01 PM, Tomas Henzl wrote:
>
>> Specifying timeout value may help in troubleshooting failures.
>>
>> Signed-off-by: David Milburn <dmilburn@redhat.com>
>> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
>> ---
>> drivers/ata/libata-core.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 40e816419f48..e1f8a01a3b92 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -1578,8 +1578,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev,
>> else
>> ata_qc_complete(qc);
>>
>> - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
>> - command);
>> + ata_dev_warn(dev, "qc timeout after %lu msecs (cmd 0x%x)\n",
>> + timeout, command);
> The 'timeout' parameter is now *unsigned int*, please generate the patches
> against the libata repo's for-next branch.
ok, thanks, will do
>
> [...]
>
> MBR, Sergey
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-28 15:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-23 18:42 [PATCH] libata: specify timeout value when internal command times out David Milburn
-- strict thread matches above, loose matches on Subject: below --
2022-07-26 17:01 Tomas Henzl
2022-07-26 17:36 ` Sergei Shtylyov
2022-07-28 15:46 ` Tomas Henzl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).