From: Damien Le Moal <dlemoal@kernel.org>
To: sashiko-reviews@lists.linux.dev, Karuna Ramkumar <rkaruna@google.com>
Cc: cassel@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] ata: libata-scsi: limit simulated SCSI command copy to response length
Date: Thu, 2 Jul 2026 11:30:56 +0900 [thread overview]
Message-ID: <16780c1b-418a-4555-b4bd-d442cedd620e@kernel.org> (raw)
In-Reply-To: <20260702021411.B01331F000E9@smtp.kernel.org>
On 7/2/26 11:14, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>
> Pre-existing issues:
> - [Critical] The defensive bounds check `WARN_ON(len > ATA_SCSI_RBUF_SIZE)` is ineffective because it evaluates after the `actor` callback has already performed an out-of-bounds write.
Karuna,
Sashiko has a good point here. Let's work on fixing this with an incremental patch.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-07-02 2:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 2:01 [PATCH v2] ata: libata-scsi: limit simulated SCSI command copy to response length Karuna Ramkumar
2026-07-02 2:14 ` sashiko-bot
2026-07-02 2:30 ` Damien Le Moal [this message]
2026-07-06 23:10 ` Karuna Ramkumar
2026-07-07 1:10 ` Damien Le Moal
2026-07-03 6:17 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16780c1b-418a-4555-b4bd-d442cedd620e@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=rkaruna@google.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox