Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH][RFC] ide: pdc202xxx_new: Remove do_gettimeofday() usage for ktime_get
Date: Wed, 07 Jan 2015 22:37:50 +0100	[thread overview]
Message-ID: <1721240.TWtHUuoOhJ@wuerfel> (raw)
In-Reply-To: <1420664493-7041-1-git-send-email-john.stultz@linaro.org>

On Wednesday 07 January 2015 13:01:33 John Stultz wrote:
> +       usec_elapsed = (long)ktime_to_ns(ktime_sub(end_time, start_time))/1000;
> 

This should use ktime_us_delta for brevity. Doing the 32-bit division that
you have here is probably slightly more efficient because it avoids do_div(),
but it's not performance critical.

	Arnd

      reply	other threads:[~2015-01-07 21:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 21:01 [PATCH][RFC] ide: pdc202xxx_new: Remove do_gettimeofday() usage for ktime_get John Stultz
2015-01-07 21:37 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1721240.TWtHUuoOhJ@wuerfel \
    --to=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=john.stultz@linaro.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox