* [PATCH] ide.c: microscopic size and readability optimization
@ 2007-05-17 11:25 Borislav Petkov
2007-05-17 11:33 ` Paul Sokolovsky
2007-05-17 12:06 ` Alan Cox
0 siblings, 2 replies; 4+ messages in thread
From: Borislav Petkov @ 2007-05-17 11:25 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide, lkml
-----
From: bbpetkov@yahoo.de
A very small size (object file 432 bytes smaller) and readability optimization of ide.c
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
--
Index: 22-rc1/drivers/ide/ide.c
===================================================================
--- 22-rc1/drivers/ide/ide.c.orig
+++ 22-rc1/drivers/ide/ide.c
@@ -568,10 +568,8 @@ void ide_unregister(unsigned int index)
ide_hwgroup_t *hwgroup;
int irq_count = 0, unit;
- BUG_ON(index >= MAX_HWIFS);
+ BUG_ON(index >= MAX_HWIFS || in_interrupt() || irqs_disabled());
- BUG_ON(in_interrupt());
- BUG_ON(irqs_disabled());
down(&ide_cfg_sem);
spin_lock_irq(&ide_lock);
hwif = &ide_hwifs[index];
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ide.c: microscopic size and readability optimization
2007-05-17 11:25 [PATCH] ide.c: microscopic size and readability optimization Borislav Petkov
@ 2007-05-17 11:33 ` Paul Sokolovsky
2007-05-17 12:06 ` Alan Cox
1 sibling, 0 replies; 4+ messages in thread
From: Paul Sokolovsky @ 2007-05-17 11:33 UTC (permalink / raw)
To: Borislav Petkov; +Cc: bzolnier, linux-ide, lkml
Hello Borislav,
Thursday, May 17, 2007, 2:25:54 PM, you wrote:
> -----
> From: bbpetkov@yahoo.de
> A very small size (object file 432 bytes smaller) and readability optimization of ide.c
And how these "optimizations" fit with BUG_ON() purpose - to
be able to easily identify cause and place of the failure? You
could just remove them altogether and claim that you did even "better"
"optimization".
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
> --
> Index: 22-rc1/drivers/ide/ide.c
> ===================================================================
> --- 22-rc1/drivers/ide/ide.c.orig
> +++ 22-rc1/drivers/ide/ide.c
> @@ -568,10 +568,8 @@ void ide_unregister(unsigned int index)
> ide_hwgroup_t *hwgroup;
> int irq_count = 0, unit;
> - BUG_ON(index >= MAX_HWIFS);
> + BUG_ON(index >= MAX_HWIFS || in_interrupt() || irqs_disabled());
> - BUG_ON(in_interrupt());
> - BUG_ON(irqs_disabled());
> down(&ide_cfg_sem);
--
Best regards,
Paul mailto:pmiscml@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ide.c: microscopic size and readability optimization
2007-05-17 11:25 [PATCH] ide.c: microscopic size and readability optimization Borislav Petkov
2007-05-17 11:33 ` Paul Sokolovsky
@ 2007-05-17 12:06 ` Alan Cox
2007-05-18 8:28 ` Borislav Petkov
1 sibling, 1 reply; 4+ messages in thread
From: Alan Cox @ 2007-05-17 12:06 UTC (permalink / raw)
To: bbpetkov; +Cc: bzolnier, linux-ide, lkml
On Thu, 17 May 2007 13:25:54 +0200
Borislav Petkov <bbpetkov@yahoo.de> wrote:
> -----
> From: bbpetkov@yahoo.de
>
> A very small size (object file 432 bytes smaller) and readability optimization of ide.c
>
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Bad idea. Now you won't know which of the conditions caused the BUG() to
occur.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ide.c: microscopic size and readability optimization
2007-05-17 12:06 ` Alan Cox
@ 2007-05-18 8:28 ` Borislav Petkov
0 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2007-05-18 8:28 UTC (permalink / raw)
To: Alan Cox; +Cc: bzolnier, linux-ide, lkml
--- Alan Cox <alan@lxorguk.ukuu.org.uk> schrieb:
> On Thu, 17 May 2007 13:25:54 +0200
> Borislav Petkov <bbpetkov@yahoo.de> wrote:
>
> > -----
> > From: bbpetkov@yahoo.de
> >
> > A very small size (object file 432 bytes smaller)
> and readability optimization of ide.c
> >
> > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
>
> Bad idea. Now you won't know which of the conditions
> caused the BUG() to
> occur.
Ups, sorry, that I hadn't considered. Nevermind the
noise.
Boris.
___________________________________________________________
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-18 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-17 11:25 [PATCH] ide.c: microscopic size and readability optimization Borislav Petkov
2007-05-17 11:33 ` Paul Sokolovsky
2007-05-17 12:06 ` Alan Cox
2007-05-18 8:28 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).