From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>,
Igor Pylypiv <ipylypiv@google.com>,
linux-kernel@vger.kernel.org
Cc: Niklas Cassel <cassel@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Xingui Yang <yangxingui@huawei.com>,
linux-ide@vger.kernel.org,
Sergey Shtylyov <sergei.shtylyov@gmail.com>
Subject: Re: [PATCH v=2] ata: libata-scsi: fix requeue of deferred ATA PASS-THROUGH commands
Date: Sun, 12 Apr 2026 20:11:19 +0200 [thread overview]
Message-ID: <177601670536.2584527.11395508886922734288.b4-ty@kernel.org> (raw)
In-Reply-To: <20260412153637.475606-1-ipylypiv@google.com>
On Sun, 12 Apr 2026 08:36:37 -0700, Igor Pylypiv wrote:
> Commit 0ea84089dbf6 ("ata: libata-scsi: avoid Non-NCQ command starvation")
> introduced ata_scsi_requeue_deferred_qc() to handle commands deferred
> during resets or NCQ failures. This deferral logic completed commands
> with DID_SOFT_ERROR to trigger a retry in the SCSI mid-layer.
>
> However, DID_SOFT_ERROR is subject to scsi_cmd_retry_allowed() checks.
> ATA PASS-THROUGH commands sent via SG_IO ioctl have scmd->allowed set
> to zero. This causes the mid-layer to fail the command immediately
> instead of retrying, even though the command was never actually issued
> to the hardware.
>
> [...]
Hello Igor,
Considering that Linus is expected for release 7.0 any minute now (it is
already Sunday afternoon), it seems too late to send this as a PR for 7.0.
The fix will have to be backported to v7.0 stable instead.
Therefore, I rebased your patch on libata/for-next
(without any parens - the comment from Sergey).
Applied to libata/linux.git (for-7.1), thanks!
[1/1] ata: libata-scsi: fix requeue of deferred ATA PASS-THROUGH commands
https://git.kernel.org/libata/linux/c/8ebf408e
Kind regards,
Niklas
prev parent reply other threads:[~2026-04-12 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 15:36 [PATCH v=2] ata: libata-scsi: fix requeue of deferred ATA PASS-THROUGH commands Igor Pylypiv
2026-04-12 16:32 ` Sergey Shtylyov
2026-04-12 18:11 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177601670536.2584527.11395508886922734288.b4-ty@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=ipylypiv@google.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sergei.shtylyov@gmail.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox