From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Date: Wed, 22 Mar 2017 18:49:12 +0100 Message-ID: <1819267.Nm9hpTOhuY@amdc3058> References: <1489509414-11491-1-git-send-email-b.zolnierkie@samsung.com> <1489509414-11491-2-git-send-email-b.zolnierkie@samsung.com> <8fc9171f-15b7-2c6a-d0b5-3af21cc88405@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: <8fc9171f-15b7-2c6a-d0b5-3af21cc88405@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Sekhar Nori Cc: Tejun Heo , Sergei Shtylyov , Kevin Hilman , Arnd Bergmann , Russell King , Dmitry Eremin-Solenikov , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-ide@vger.kernel.org Hi, On Tuesday, March 21, 2017 02:04:38 PM Sekhar Nori wrote: > Hi, > > On Tuesday 14 March 2017 10:06 PM, Bartlomiej Zolnierkiewicz wrote: > > Add Palmchip BK3710 PATA controller driver. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > There are some checkpatch suggestions that are worth fixing, I think. > > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz - 2017-03-14 2206.eml:277: CHECK: Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz - 2017-03-14 2206.eml:320: CHECK: Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz - 2017-03-14 2206.eml:489: CHECK: Comparison to NULL could be written "!mem" Will be fixed in v3, thanks. [ My scripts didn't run checkpatch with --strict so I haven't noticed them. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics