From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tj@kernel.org, sergei.shtylyov@cogentembedded.com,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error
Date: Tue, 05 Dec 2017 15:02:13 +0100 [thread overview]
Message-ID: <1823468.mnqCj3ft5Z@amdc3058> (raw)
In-Reply-To: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com>
On Saturday, November 25, 2017 04:04:07 PM Arvind Yadav wrote:
> Fix these checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
>
> ERROR: space prohibited after that '~' (ctx:WxW)
> + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
>
> ERROR: spaces required around that '?' (ctx:VxW)
> + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
>
> ERROR: that open brace { should be on the previous line
> + const struct ata_port_info *ppi[] =
> + { &pdc2027x_port_info[board_idx], NULL };
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-12-05 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171125103419epcas5p1e02e8409d9cb34cd3c592ca4e14961eb@epcas5p1.samsung.com>
2017-11-25 10:34 ` [PATCH] pata_pdc2027x: Fix coding sytle error Arvind Yadav
2017-11-25 11:02 ` Joe Perches
2017-11-25 11:10 ` arvindY
2017-12-05 14:02 ` Bartlomiej Zolnierkiewicz [this message]
2017-12-05 14:12 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1823468.mnqCj3ft5Z@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox