From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>
Subject: Re: [PATCH v3 2/3] ata: libata-eh: Simplify reset operation management
Date: Tue, 15 Jul 2025 16:54:07 +0200 [thread overview]
Message-ID: <1a3e3418-18ae-4344-ad05-d7076a3bc8e4@suse.de> (raw)
In-Reply-To: <20250711083544.231706-3-dlemoal@kernel.org>
On 7/11/25 10:35, Damien Le Moal wrote:
> Introduce struct ata_reset_operations do aggregate in a single structure
> the definitions of the 4 reset methods (prereset, softreset, hardreset
> and postreset) for a port. This new structure is used in struct ata_port
> to define the reset methods for a regular port (reset field) and for a
> port-multiplier port (pmp_reset field). A pointer to either of these
> fields replaces the 4 reset method arguments passed to ata_eh_recover()
> and ata_eh_reset().
>
> ata_std_error_handler() is modified to use the ATA_LFLAG_NO_HRST link
> flag to prevents the use of built-in hardreset methods for ports without
> a valid scr. This flag is checked in ata_eh_reset() and if set, the
> hardreset method is ignored.
>
> The definition of the reset methods for all drivers is changed to use
> the reset and pmp_reset fields in struct ata_port_operations.
>
> A large number of files is modifed, but no functional changes are
> introduced.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> drivers/ata/ahci.c | 6 +--
> drivers/ata/ahci_da850.c | 6 +--
> drivers/ata/ahci_dm816.c | 2 +-
> drivers/ata/ahci_imx.c | 13 ++++---
> drivers/ata/ahci_qoriq.c | 4 +-
> drivers/ata/ahci_xgene.c | 8 ++--
> drivers/ata/ata_piix.c | 4 +-
> drivers/ata/libahci.c | 10 ++---
> drivers/ata/libata-core.c | 4 +-
> drivers/ata/libata-eh.c | 49 ++++++++++++-------------
> drivers/ata/libata-pmp.c | 26 +++++--------
> drivers/ata/libata-sata.c | 2 +-
> drivers/ata/libata-sff.c | 8 ++--
> drivers/ata/libata.h | 8 ++--
> drivers/ata/pata_acpi.c | 2 +-
> drivers/ata/pata_ali.c | 10 ++---
> drivers/ata/pata_amd.c | 4 +-
> drivers/ata/pata_artop.c | 4 +-
> drivers/ata/pata_atiixp.c | 2 +-
> drivers/ata/pata_efar.c | 2 +-
> drivers/ata/pata_ep93xx.c | 4 +-
> drivers/ata/pata_hpt366.c | 2 +-
> drivers/ata/pata_hpt37x.c | 4 +-
> drivers/ata/pata_hpt3x2n.c | 2 +-
> drivers/ata/pata_icside.c | 2 +-
> drivers/ata/pata_it8213.c | 2 +-
> drivers/ata/pata_jmicron.c | 2 +-
> drivers/ata/pata_marvell.c | 2 +-
> drivers/ata/pata_mpiix.c | 2 +-
> drivers/ata/pata_ns87410.c | 2 +-
> drivers/ata/pata_octeon_cf.c | 2 +-
> drivers/ata/pata_oldpiix.c | 2 +-
> drivers/ata/pata_opti.c | 2 +-
> drivers/ata/pata_optidma.c | 2 +-
> drivers/ata/pata_parport/pata_parport.c | 3 +-
> drivers/ata/pata_pdc2027x.c | 2 +-
> drivers/ata/pata_rdc.c | 2 +-
> drivers/ata/pata_sis.c | 2 +-
> drivers/ata/pata_sl82c105.c | 2 +-
> drivers/ata/pata_triflex.c | 2 +-
> drivers/ata/pata_via.c | 2 +-
> drivers/ata/pdc_adma.c | 2 +-
> drivers/ata/sata_dwc_460ex.c | 2 +-
> drivers/ata/sata_fsl.c | 6 +--
> drivers/ata/sata_highbank.c | 2 +-
> drivers/ata/sata_inic162x.c | 2 +-
> drivers/ata/sata_mv.c | 10 ++---
> drivers/ata/sata_nv.c | 2 +-
> drivers/ata/sata_promise.c | 4 +-
> drivers/ata/sata_qstor.c | 4 +-
> drivers/ata/sata_rcar.c | 2 +-
> drivers/ata/sata_sil24.c | 8 ++--
> drivers/ata/sata_svw.c | 4 +-
> drivers/ata/sata_sx4.c | 2 +-
> drivers/ata/sata_uli.c | 2 +-
> drivers/ata/sata_via.c | 4 +-
> drivers/scsi/libsas/sas_ata.c | 4 +-
> include/linux/libata.h | 17 +++++----
> 58 files changed, 143 insertions(+), 155 deletions(-)
>
You may want to run a spell-checker for the description.
Otherwise:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-07-15 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 8:35 [PATCH v3 0/3] libata-eh cleanups Damien Le Moal
2025-07-11 8:35 ` [PATCH v3 1/3] ata: libata-eh: Remove ata_do_eh() Damien Le Moal
2025-07-15 14:50 ` Hannes Reinecke
2025-07-11 8:35 ` [PATCH v3 2/3] ata: libata-eh: Simplify reset operation management Damien Le Moal
2025-07-11 9:06 ` Niklas Cassel
2025-07-11 10:45 ` John Garry
2025-07-15 14:54 ` Hannes Reinecke [this message]
2025-07-11 8:35 ` [PATCH v3 3/3] Documentation: driver-api: Update libata error handler information Damien Le Moal
2025-07-11 9:07 ` Niklas Cassel
2025-07-15 14:54 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a3e3418-18ae-4344-ad05-d7076a3bc8e4@suse.de \
--to=hare@suse.de \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).