From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Xin Gao <gaoxin@cdjrlc.com>
Cc: s.shtylyov@omp.ru, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Date:do not initialise statics to 0
Date: Tue, 19 Jul 2022 20:45:37 +0900 [thread overview]
Message-ID: <1ac89860-957f-a24d-82ee-d40e5345d04e@opensource.wdc.com> (raw)
In-Reply-To: <20220719112908.7333-1-gaoxin@cdjrlc.com>
On 7/19/22 20:29, Xin Gao wrote:
> do not initialise statics to 0
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> drivers/ata/pata_artop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
> index 20a8f31a3f57..1aad8df2ea87 100644
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -37,7 +37,7 @@
> * test stuff.
> */
>
> -static int clock = 0;
> +static int clock;
>
> /**
> * artop62x0_pre_reset - probe begin
Very weird patch title.
Is this solving any static analyzer or compiler warning ? If not, this is
not a very useful change.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2022-07-19 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 11:29 [PATCH] Date:do not initialise statics to 0 Xin Gao
2022-07-19 11:45 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ac89860-957f-a24d-82ee-d40e5345d04e@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=gaoxin@cdjrlc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox