Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Hajo Noerenberg <hajo-linux-ide@noerenberg.de>,
	linux-ide@vger.kernel.org
Cc: Pali Rohar <pali@kernel.org>, risc4all@yahoo.com
Subject: Re: [PATCH] ata: ahci: clear HOST_IRQ_STAT before the ports on Marvell 88SE61xx
Date: Fri, 28 Aug 2026 14:43:47 +0900	[thread overview]
Message-ID: <1f90bdf2-3aa8-4f39-9a32-627aeb400aea@kernel.org> (raw)
In-Reply-To: <ed203607-19a9-4dd3-89b2-ba94b1bde4c0@noerenberg.de>

On 8/25/26 16:58, Hajo Noerenberg wrote:
> 
> Damien,
> 
> thank you for the quick review.
> 
> On 8/25/26 02:51, Damien Le Moal wrote:
>> The commit title is not great as "before the ports" is not very clear.
>> What does "clear the ports" mean? Though I do not have a better alternative
>> title (yet).
> 
> Agreed, and "the ports" was meant to be the ports' PxIS registers, which the
> title does not say.  Would this be better?
> 
>   ata: ahci: work around lost interrupts on Marvell 88SE61xx

That is better!

> I tried exactly that: a build that registers the existing
> ahci_thunderx_irq_handler() unchanged for board_ahci_mv, taken out of the
> #ifdef CONFIG_ARM64, with a dev_info() so I could be certain which handler was
> really active.  It does not work.  The controller fails exactly as it does
> without any patch.

OK. Understood. Please resend the patch with the fixed-up commit title and we'll
apply it.

-- 
Damien Le Moal
Western Digital Research

      reply	other threads:[~2026-08-28  5:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 11:26 [PATCH] ata: ahci: clear HOST_IRQ_STAT before the ports on Marvell 88SE61xx Hajo Noerenberg
2026-08-25  0:51 ` Damien Le Moal
2026-08-25  7:58   ` Hajo Noerenberg
2026-08-28  5:43     ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f90bdf2-3aa8-4f39-9a32-627aeb400aea@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=hajo-linux-ide@noerenberg.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=risc4all@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox