Re: Oops on boot with TCQ enabled (VIA KT133A)

[Jan Dittmer <jan@jandittmer.de>]

> > > There _may_ be issues with changing depth on the fly. So if you could
> > > just test without fiddling with changing depths that would be great.
> >
> > Ok. No changes in /proc using_tcq after boot, assuming it's enabled
> > automatically (checked that in kernel config0, it works perfectly fine.
>
> Thanks for verifying that! Jan, you appeared to have problems even with
> tcq-per-default enabled and not touching the depth while running io, is
> that correct?

Thats correct. But I couldn't reproduce it, after applying the following 
changeset. But that doesn't seem very related (I got some oops' while playing 
a video). But iirc I always watched a music video when file system corruption 
appeared?!
I'll try tomorrow evening without this change if I can reproduce the 
problem...

jan


--- emufx.c     11 Oct 2002 13:29:36 -0000      1.23
+++ emufx.c     19 Oct 2002 14:29:43 -0000
@@ -413,7 +413,7 @@

        snd_runtime_check(emu, return -EINVAL);
        snd_runtime_check(handler, return -EINVAL);
-       irq = kmalloc(sizeof(*irq), GFP_KERNEL);
+       irq = kmalloc(sizeof(*irq), GFP_ATOMIC);
        if (irq == NULL)
                return -ENOMEM;
        irq->handler = handler;