Re: Success(?) with SiI + Seagate pessimistic fix disabled.

[Eric Wong <normalperson@yhbt.net>]

Eric Wong <normalperson@yhbt.net> wrote:
<snip success story>

I'm not feeling any more pessimistic than usual at the moment, so I
might as well start a one item whitelist.  It works for me, but more
testing is always a good thing.

On a related note, I couldn't find a way to get the firmware revision
from hdparm or dmesg when using libata.

--- a/drivers/scsi/sata_sil.c
+++ b/drivers/scsi/sata_sil.c
@@ -65,6 +65,15 @@ static struct pci_device_id sil_pci_tbl[
 	{ }	/* terminate list */
 };
 
+
+/* TODO firmware versions should be added - eric */
+struct sil_drivelist {
+	char * product;
+} sil_whitelist [] = {
+	{ "ST3160023AS" }, /* firmware 3.05 */
+	{ 0 }
+};
+
 static struct pci_driver sil_pci_driver = {
 	.name			= DRV_NAME,
 	.id_table		= sil_pci_tbl,
@@ -184,6 +194,7 @@ static void sil_scr_write (struct ata_po
  */
 static void sil_dev_config(struct ata_port *ap, struct ata_device *dev)
 {
+	int n;
 	const char *s = &dev->product[0];
 	unsigned int len = strnlen(s, sizeof(dev->product));
 
@@ -191,6 +202,12 @@ static void sil_dev_config(struct ata_po
 	while ((len > 0) && (s[len - 1] == ' '))
 		len--;
 
+	/* check against whitelist */
+	for (n = 0; sil_whitelist[n].product; n++)
+		if ( (len == strlen(sil_whitelist[n].product))
+		&& !strncmp(sil_whitelist[n].product,s,len) )
+			return;
+
 	/* limit to udma5 */
 	if (!memcmp(s, "Maxtor ", 7)) {
 		printk(KERN_INFO "ata%u(%u): applying pessimistic Maxtor errata fix\n",

-- 
Eric Wong