Re: [2.4 IDE PATCH] SanDisk is flash (fwd)

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Tuesday 13 of April 2004 21:53, Adrian Bunk wrote:
> The patch forwarded below by Meelis Roos was already included in
> 2.4.26-rc. It does apply against 2.6, too, so I assume it should also be
> added there?

Some time ago I sent mail to Meelis asking if this patch is really necessary.
No answer yet.

> cu
> Adrian
>
>
> ----- Forwarded message from Meelis Roos <mroos@linux.ee> -----
>
> Date:	Thu, 1 Apr 2004 21:26:13 +0300 (EEST)
> From: Meelis Roos <mroos@linux.ee>
> To: Linux Kernel list <linux-kernel@vger.kernel.org>
> Subject: [2.4 IDE PATCH] SanDisk is flash
>
> This is self-explanatory - former SunDisk renamed itself to SanDisk and
> now there are flash disks with both names.

Please excuse me but I am dumb... ;-)

Does this mean that CF test fail or that SunDisk is SanDisk now?

id->config == 0x848a test was introduced in kernel 2.3.27 _after_
SunDisk model name test and if id->config == 0x848a test fails
comment to drive_is_flashcard() needs fixing.

> ===== drivers/ide/ide-probe.c 1.21 vs edited =====
> --- 1.21/drivers/ide/ide-probe.c	Mon Nov 24 00:05:18 2003
> +++ edited/drivers/ide/ide-probe.c	Thu Apr  1 21:15:22 2004
> @@ -102,7 +102,8 @@
>  		if (id->config == 0x848a) return 1;	/* CompactFlash */
>  		if (!strncmp(id->model, "KODAK ATA_FLASH", 15)	/* Kodak */
>
>  		 || !strncmp(id->model, "Hitachi CV", 10)	/* Hitachi */
>
> -		 || !strncmp(id->model, "SunDisk SDCFB", 13)	/* SunDisk */
> +		 || !strncmp(id->model, "SunDisk SDCFB", 13)	/* old SanDisk */
> +		 || !strncmp(id->model, "SanDisk SDCFB", 13)	/* SanDisk */
>
>  		 || !strncmp(id->model, "HAGIWARA HPC", 12)	/* Hagiwara */
>  		 || !strncmp(id->model, "LEXAR ATA_FLASH", 15)	/* Lexar */
>  		 || !strncmp(id->model, "ATA_FLASH", 9))	/* Simple Tech */