Re: [PATCH] remove dead drivers/ide/ppc/swarm.c

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Tuesday 04 of May 2004 14:28, Bartlomiej Zolnierkiewicz wrote:
> Hi Ralf,
>
> On Tuesday 04 of May 2004 13:19, Ralf Baechle wrote:
> > On Tue, May 04, 2004 at 01:34:22AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > This driver was merged in 2.5.32 but depends on
> > > <asm/sibyte/swarm_ide.h> which hasn't been merged in 2.5.  Additionally
> > > it is a MIPS specific driver so it should be in drivers/ide/mips/ if
> > > somebody ever decides to re-add it.
> >
> > No.  I've already sent a proper patch instead of just a chainsaw massacre
> > to akpm.
>
> It is not integrated into -mm (2.6.6-rc3-mm1) yet so I couldn't see it.
> [ Please cc: me on IDE patches. ]
>
> If it looks the same as in linux-mips CVS it won't work because I've killed
> ide_init_default_hwifs() recently (except ARM but patch is pending).
>
> Sorry, this is what you get when using hacks. 8)

Actually SiByte IDE seems to be broken even in linux-mips CVS since
at least 5 months due to this change:

http://www.linux-mips.org/cvsweb/linux/include/asm-mips/ide.h.diff?r1=1.23&r2=1.24

which causes conflicts between swarm.c private ide_init_default_hwifs() hack
and the one from <asm/mach-generic/ide.h> (I can't find other ide.h).

Bartlomiej