From: Marc Singer <elf@buici.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: rmk@arm.linux.org.uk, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: arm-lh7a40x IDE support in 2.6.6
Date: Fri, 14 May 2004 17:10:28 -0700 [thread overview]
Message-ID: <20040515001028.GA9500@buici.com> (raw)
In-Reply-To: <200405150126.33153.bzolnier@elka.pw.edu.pl>
On Sat, May 15, 2004 at 01:26:33AM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Saturday 15 of May 2004 00:49, Marc Singer wrote:
> > On Sat, May 15, 2004 at 12:19:46AM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> > > > > > > - you are setting IDE_NO_IRQ in ide_init_hwif_ports() which is
> > > > > > > used in many places in generic IDE code - anybody wanting to
> > > > > > > understand interactions with your code + generic code will have
> > > > > > > serious problems (especially if knows _nothing_ about lpd7a40x)
> > > > > >
> > > > > > I don't know what you mean. I grep for that constant and found it
> > > > > > nowhere except for ide-io.c and in my code. It doesn't take much
> > > > > > to find the references.
> > > > >
> > > > > I'm talking about ide_init_hwif_ports() function.
> > > >
> > > > Most of the ARM arch's use it. Perhaps all of them need a good once
> > > > over.
> > >
> > > Since some time I have a patch killing <asm/arch-*/ide.h>. :)
> >
> > OK. That raises an interesting question. If a) you as the IDE
> > maintainer want to make a policy change, and b) you have a concrete
> > action to take, then how do you go about it so that the right thing
> > (tm) happens?
>
> I posted patch to linux-arm-kernel (rmk, I can't find it in l-a-k archives
> and I also can't find any mail about it being rejected?) and linux-ide.
> [ and to affected arch maintainers of course ]
There is a web page for posting kernel patches. It is most likely to
receive attention than posting to the mailing list.
<http://www.arm.linux.org.uk/developer/patches/>
> > One tack would be to post to the ARM list stating that there is
> > such-and-such, a new policy, and this requires a change to the
> > way-things-work (tm). Then effect a patch that breaks the bad stuff
> > so that the users of such bad stuff must cope.
>
> It is stable kernel series so I paid 'stable kernel' price
> and made sure that it shouldn't break anything.
Fair enough. We'll start with lh and see if we can get others to
follow.
next prev parent reply other threads:[~2004-05-15 0:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 16:40 arm-lh7a40x IDE support in 2.6.6 Bartlomiej Zolnierkiewicz
2004-05-14 16:52 ` Bartlomiej Zolnierkiewicz
2004-05-14 17:28 ` Marc Singer
2004-05-14 17:26 ` Marc Singer
2004-05-14 18:45 ` Bartlomiej Zolnierkiewicz
2004-05-14 19:47 ` Marc Singer
2004-05-14 21:23 ` Bartlomiej Zolnierkiewicz
2004-05-14 21:33 ` Marc Singer
2004-05-14 22:19 ` Bartlomiej Zolnierkiewicz
2004-05-14 22:49 ` Marc Singer
2004-05-14 23:26 ` Bartlomiej Zolnierkiewicz
2004-05-15 0:10 ` Marc Singer [this message]
2004-05-15 0:25 ` Bartlomiej Zolnierkiewicz
2004-05-15 0:33 ` Marc Singer
2004-05-14 19:52 ` Russell King
2004-05-14 20:25 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040515001028.GA9500@buici.com \
--to=elf@buici.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).