Re: [PATCH] [STACK] reduce >3k call path in ide

["Jörn Engel" <joern@wohnheim.fh-wedel.de>]

On Wed, 16 June 2004 10:37:41 -0700, Randy.Dunlap wrote:
> 
> Thanks for the helpful comments.  Here's a corrected patch.

Looks, as if it still leaks memory:

>  
>      link->state &= ~DEV_CONFIG_PENDING;

about here.

>      return;
> -    
> +
>  cs_failed:
>      cs_error(link->handle, last_fn, last_ret);
>  failed:
>      ide_release(link);
>      link->state &= ~DEV_CONFIG_PENDING;
> +    return;
>  
> +    /* memory allocation errors */
> +err_kfree:
> +    kfree(cfginfo);
> +    kfree(def_cte);
> +    kfree(tbuf);
> +    printk(KERN_NOTICE "ide-cs: ide_config failed memory allocation\n");
> +    goto failed;
>  } /* ide_config */
>  
>  /*======================================================================

Jörn

-- 
Schrödinger's cat is <BLINK>not</BLINK> dead.
-- Illiad